You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/06/13 06:38:40 UTC
[GitHub] [maven-fluido-skin] kwin opened a new pull request, #36: [MSKINS-193] remove loading 3rd party resources for Google site search
kwin opened a new pull request, #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36
use simple placeholder
remove JS loaded from Google
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] asfgit closed pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
URL: https://github.com/apache/maven-fluido-skin/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1160542680
@michael-o Any chance you can look at this and the PR for MSKINS-194?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] kwin commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
kwin commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1154790597
The reasoning is outlined in https://issues.apache.org/jira/browse/MSKINS-193. In short "Google must not collect data about a visitor of a site generated by maven-fluido-skin". As you can see in this PR, the external resources have been removed completely (which is even faster than delivering it from any CDN :-))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1160548020
This is something I will definitively process after I finish Doxia Sitetools 2.0.0-M3 vote. This is not forgotten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] michael-o commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1153544906
Will take care of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
stevecrox commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1154782537
Could I ask the thinking behind the change?
The facebook, pwiki and google analytic options all require external resources to function and even if those resources were bundled with the skin the functionality for social media and google parts require internet access to work.
The css here references a CDN resource which should be cached by the browser so should mean it loads quickly.
Which has me struggling to understand your motivation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-fluido-skin] stevecrox commented on pull request #36: [MSKINS-193] remove loading 3rd party resources for Google site search
Posted by GitBox <gi...@apache.org>.
stevecrox commented on PR #36:
URL: https://github.com/apache/maven-fluido-skin/pull/36#issuecomment-1155708962
That is not something I thought of.
For me this builds, the search box remains in the topbar and sidebar and looks fine. The search functionality still works in both versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org