You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by bryancall <gi...@git.apache.org> on 2016/06/28 23:09:12 UTC
[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/760
TS-4542: ASAN error with HTTP/2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4542
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/760.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #760
----
commit 8a364a7dd35b4e499ba551a731420a887bb8fc60
Author: Bryan Call <bc...@apache.org>
Date: 2016-06-28T21:31:46Z
TS-4542: ASAN error with HTTP/2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/277/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on the issue:
https://github.com/apache/trafficserver/pull/760
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/276/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/760
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/380/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/760#discussion_r68876890
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
return HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD;
}
- if (stream->is_body_done() && payload_length < available_size) {
+ if (stream->is_body_done() && payload_length <= available_size) {
--- End diff --
This could be problem when response body size is larger than 16375.
```
$ /opt/nghttp2/bin/nghttp -n "https://127.0.0.1:4443/httpbin/bytes/16376"
Some requests were not processed. total=1, processed=0
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/374/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/760#discussion_r68882501
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
return HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD;
}
- if (stream->is_body_done() && payload_length < available_size) {
+ if (stream->is_body_done() && payload_length <= available_size) {
--- End diff --
Yeah, I updated the patch with <= so that it would set the END_STREAM on a 0 length frame. Thanks for the feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/381/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #760: TS-4542: ASAN error with HTTP/2
Posted by masaori335 <gi...@git.apache.org>.
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/760#discussion_r68878648
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream *stream, size_t &payload_len
return HTTP2_SEND_A_DATA_FRAME_NO_PAYLOAD;
}
- if (stream->is_body_done() && payload_length < available_size) {
+ if (stream->is_body_done() && payload_length <= available_size) {
--- End diff --
IMO, to stop sending 0 payload DATA frame with END_STREAM flag, we need to check read available size of current_reader. Something like this.
https://paste.apache.org/8eVP
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/268/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/270/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #760: TS-4542: ASAN error with HTTP/2
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/760
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/372/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---