You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Dmitry Sysolyatin (Jira)" <ji...@apache.org> on 2023/11/11 21:00:00 UTC

[jira] [Resolved] (CALCITE-6100) The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison

     [ https://issues.apache.org/jira/browse/CALCITE-6100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dmitry Sysolyatin resolved CALCITE-6100.
----------------------------------------
    Fix Version/s: 1.37.0
       Resolution: Fixed

> The equalsDeep of SqlRowTypeNameSpec should use equalsDeep for fieldTypes rather than reference comparison
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-6100
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6100
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.35.0, 1.36.0
>            Reporter: Dmitry Sysolyatin
>            Assignee: Dmitry Sysolyatin
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.37.0
>
>
> SqlRowTypeNameSpec#equalsDeep method uses reference comparison for objects inside fieldTypes list instead of using SqlDataTypeSpec#equalsDeep.
> Testcase: Add to `SqlEqualsDeepTest` the following lines of code:
> {code:java}
> @Test
> void testRowEqualsDeep() throws SqlParseException {
> assertEqualsDeep("CAST(a AS ROW(field INTEGER))",
> "CAST(a AS ROW(field INTEGER))", true);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)