You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/10/27 10:53:45 UTC
[GitHub] [incubator-devlake] abeizn opened a new pull request, #3597: feat: the GetBlueprintPipelines interface support page/pagesize/statu…
abeizn opened a new pull request, #3597:
URL: https://github.com/apache/incubator-devlake/pull/3597
…s/pending params
### ⚠️ Pre Checklist
> Please complete _ALL_ items in this checklist, and remove before submitting
- [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
- [ ] I have added relevant tests.
- [ ] I have added relevant documentation.
- [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
# Summary
update gin accept params logic, blueprintId---> param in PipelineQuery
### Does this close any open issues?
Closes #3594
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #3597: feat: the GetBlueprintPipelines interface support page/pagesize/statu…
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #3597:
URL: https://github.com/apache/incubator-devlake/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3597: feat: the GetBlueprintPipelines interface support page/pagesize/statu…
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3597:
URL: https://github.com/apache/incubator-devlake/pull/3597#discussion_r1006718721
##########
api/blueprints/blueprints.go:
##########
@@ -212,14 +212,18 @@ func Trigger(c *gin.Context) {
// @Failure 500 {string} errcode.Error "Internel Error"
// @Router /blueprints/{blueprintId}/pipelines [get]
func GetBlueprintPipelines(c *gin.Context) {
- blueprintId := c.Param("blueprintId")
- id, err := strconv.ParseUint(blueprintId, 10, 64)
+ var query services.PipelineQuery
+ err := c.ShouldBindQuery(&query)
+ if err != nil {
+ shared.ApiOutputError(c, errors.BadInput.Wrap(err, shared.BadRequestBody))
+ return
+ }
+ err = c.ShouldBindUri(&query)
Review Comment:
Why bind twice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org