[jira] [Commented] (LUCENE-5708) Remove IndexWriterConfig.clone

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14009722#comment-14009722 ] 

Shai Erera commented on LUCENE-5708:
------------------------------------

I think the way you fixed some tests that used clone is incorrect. You should at least call {{newIndexWriterConfig(random)}} w/ the same random and seed, so the exact IWC is created each time. At least, that's what these tests now rely on, even if they don't break. Otherwise, they just create a random IWC each time they open a writer, which is not the intention I believe.

> Remove IndexWriterConfig.clone
> ------------------------------
>
>                 Key: LUCENE-5708
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5708
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/index
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5708.patch, LUCENE-5708.patch
>
>
> We originally added this clone to allow a single IWC to be re-used against more than one IndexWriter, but I think this is a mis-feature: it adds complexity to hairy classes (merge policy/scheduler, DW thread pool, etc.), I think it's buggy today.
> I think we should just disallow sharing: you must make a new IWC for a new IndexWriter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org