You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/30 17:04:00 UTC
[jira] [Commented] (ISIS-2192) Improve the mavendeps-testing, to
avoid accidental junit 4 dependency
[ https://issues.apache.org/jira/browse/ISIS-2192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17026824#comment-17026824 ]
ASF subversion and git services commented on ISIS-2192:
-------------------------------------------------------
Commit 348ce73e7ad849f4239b1d84192b1c22c7ae7a5f in isis's branch refs/heads/master from danhaywood
[ https://gitbox.apache.org/repos/asf?p=isis.git;h=348ce73 ]
ISIS-2192: splits mavendeps-testing into 3
* mavendeps-unittests
* mavendeps-integtests
* mavendeps-integspecs
> Improve the mavendeps-testing, to avoid accidental junit 4 dependency
> ---------------------------------------------------------------------
>
> Key: ISIS-2192
> URL: https://issues.apache.org/jira/browse/ISIS-2192
> Project: Isis
> Issue Type: Improvement
> Reporter: Daniel Keir Haywood
> Assignee: Daniel Keir Haywood
> Priority: Major
> Fix For: 2.0.0
>
>
> At the moment the isis-mavendeps-testing defines transitive dependencies on both unittestsupport and integtestsupport.
>
> unittestsupport defines the JMock rule stuff, which depends on junit 4: don't want to change this for now.
>
> for integtestsupport, though, want to force upgrade to junit 5, which also means removing any accidental dependencies on junit:junit:4.x
>
> The following dependency for integ tests works, but think it might be better to define two different mavendeps, one for unit testing and one for integ testing.
>
> <dependency>
> <groupId>org.apache.isis.mavendeps</groupId>
> <artifactId>isis-mavendeps-testing</artifactId>
> <type>pom</type>
> <scope>test</scope>
> <exclusions>
> <exclusion>
> <groupId>org.apache.isis.core</groupId>
> <artifactId>isis-unittestsupport</artifactId>
> </exclusion>
> <exclusion>
> <groupId>org.junit.vintage</groupId>
> <artifactId>junit-vintage-engine</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)