[jira] [Commented] (IMPALA-9666) TestImpalaShellInteractive fails in a misleading way

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088316#comment-17088316 ] 

ASF subversion and git services commented on IMPALA-9666:
---------------------------------------------------------

Commit e11d02adcbaed38d1d0d09549383408ce33fa234 in impala's branch refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=e11d02a ]

IMPALA-9666 Correct a log message in TestImpalaShellInteractive

When _wait_for_num_open_sessions() calls wait_for_metric_value() and
wait_for_metric_value() hits an assertion error then
_wait_for_num_open_sessions() catches the exception and attempts to log
a descriptive string that was passed to it as a parameter. The logging
call does not have a '%s' directive, which results in the failure being
reported as
 "TypeError: not all arguments converted during string formatting".
Fix this by adding the '%s' directive to the logging call.

Change-Id: Icfd7baed153dadceb953df30beba180128055c92
Reviewed-on: http://gerrit.cloudera.org:8080/15751
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> TestImpalaShellInteractive fails in a misleading way
> ----------------------------------------------------
>
>                 Key: IMPALA-9666
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9666
>             Project: IMPALA
>          Issue Type: Bug
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>            Priority: Major
>
> If the test fails in _wait_for_num_open_sessions then the failure says
> {code}
> E   TypeError: not all arguments converted during string formatting
> {code}
> which is the result of 
> {code}
>       LOG.exception("Error: " % err)
> {code}
> which should be
> {code}
>       LOG.exception("Error: %s" % err)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org