You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pabloem <gi...@git.apache.org> on 2017/08/04 00:48:54 UTC
[GitHub] beam pull request #3684: [BEAM-2724] Preparing support for Structured Names ...
GitHub user pabloem opened a pull request:
https://github.com/apache/beam/pull/3684
[BEAM-2724] Preparing support for Structured Names in Dataflow counters
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
---
Adding a CounterName class to help support structured names for counters in the future.
Also remove function calls from the `apiclient.py` file that are no longer used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam add-countername
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3684
----
commit b1e15abc0423ea7c8013f3d745ab97b44c04b5f5
Author: Pablo <pa...@google.com>
Date: 2017-08-04T00:46:09Z
Preparing support for Structured Names in Dataflow counters
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3684: [BEAM-2724] Preparing support for Structured Names ...
Posted by pabloem <gi...@git.apache.org>.
Github user pabloem closed the pull request at:
https://github.com/apache/beam/pull/3684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3684: [BEAM-2724] Preparing support for Structured Names ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3684
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3684: [BEAM-2724] Preparing support for Structured Names ...
Posted by pabloem <gi...@git.apache.org>.
GitHub user pabloem reopened a pull request:
https://github.com/apache/beam/pull/3684
[BEAM-2724] Preparing support for Structured Names in Dataflow counters
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
---
* Adding a CounterName class to help support structured names for counters in the future.
* Also remove function calls from the `apiclient.py` file that are no longer used.
* And also removing function calls used for aggregators, which have been dead code for a while.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam add-countername
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3684.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3684
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---