You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "David E. Jones (JIRA)" <ji...@apache.org> on 2007/05/22 18:12:16 UTC
[jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
[ https://issues.apache.org/jira/browse/OFBIZ-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497914 ]
David E. Jones commented on OFBIZ-1009:
---------------------------------------
Just a quick thought: these appear to be new features and improvements of the PayPal stuff rather than a bug fix, and probably shouldn't be included in the release branch.
> Reorganization of PayPalEvents
> ------------------------------
>
> Key: OFBIZ-1009
> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
> Project: OFBiz (The Open for Business Project)
> Issue Type: Bug
> Components: accounting
> Affects Versions: SVN trunk, Release Branch 4.0
> Environment: mac os x
> Reporter: Marco Risaliti
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
>
> I have reorganizated the PayPalEvents.java performing those tasks:
> - removing unused variable to avoid compile warning
> - removed hardcoded error messages to use uiLabels.properties
> - correct the bug that does not create the payment for the order that was paid on PayPal
> - removed an hard-coded link to production PayPal (http://www.paypal.com/cgi-bin/webscr) and retrieved from the payment.properties
> This patch can be tested also on the front-end application on http://www.ofbiz.it
> After review and commit this patch the issue OFBIZ-175 and OFBIZ-247 can be closed.
> Thanks in advance
> Marco Risaliti
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (OFBIZ-1009) Reorganization of PayPalEvents
Posted by "mrisaliti@libero.it" <mr...@libero.it>.
Yes, mainly this patch is an improvement but the bug is if you use
PayPal then during the notification the payment/payment gateway
response and order payment preference will be not be created.
So if you consider this is not a bug you can apply it on to main trunk.
Thanks a lot
Marco
Il giorno 22/mag/07, alle ore 18:12, David E. Jones (JIRA) ha scritto:
>
> [ https://issues.apache.org/jira/browse/OFBIZ-1009?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel#action_12497914 ]
>
> David E. Jones commented on OFBIZ-1009:
> ---------------------------------------
>
> Just a quick thought: these appear to be new features and
> improvements of the PayPal stuff rather than a bug fix, and
> probably shouldn't be included in the release branch.
>
>> Reorganization of PayPalEvents
>> ------------------------------
>>
>> Key: OFBIZ-1009
>> URL: https://issues.apache.org/jira/browse/OFBIZ-1009
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Bug
>> Components: accounting
>> Affects Versions: SVN trunk, Release Branch 4.0
>> Environment: mac os x
>> Reporter: Marco Risaliti
>> Priority: Minor
>> Fix For: SVN trunk, Release Branch 4.0
>>
>>
>> I have reorganizated the PayPalEvents.java performing those tasks:
>> - removing unused variable to avoid compile warning
>> - removed hardcoded error messages to use uiLabels.properties
>> - correct the bug that does not create the payment for the order
>> that was paid on PayPal
>> - removed an hard-coded link to production PayPal (http://
>> www.paypal.com/cgi-bin/webscr) and retrieved from the
>> payment.properties
>> This patch can be tested also on the front-end application on
>> http://www.ofbiz.it
>> After review and commit this patch the issue OFBIZ-175 and
>> OFBIZ-247 can be closed.
>> Thanks in advance
>> Marco Risaliti
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>