[jira] [Comment Edited] (SOLR-14258) DocList (DocSlice) should not implement DocSet

["Mikhail Khludnev (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17048291#comment-17048291 ] 

Mikhail Khludnev edited comment on SOLR-14258 at 2/29/20 12:22 PM:
-------------------------------------------------------------------

Giving that we are heading 8.5, why don't release it with deprecations, and commit removals into brant_8x right after release?


was (Author: mkhludnev):
Giving that we are heading 8.5, why don't release it with deprecations, and commit removals into brant_8x right after release. 

> DocList (DocSlice) should not implement DocSet
> ----------------------------------------------
>
>                 Key: SOLR-14258
>                 URL: https://issues.apache.org/jira/browse/SOLR-14258
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: search
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: master (9.0)
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> DocList is an internal interface used to hold the documents we'll ultimately return from search.  It has one implementation -- DocSlice.  It implements DocSet but I think that was a mistake.  Basically no-where does Solr depend on the fact that a DocList is a DocSet today, and keeping it this way complicates maintenance on DocSet's abstraction.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org