You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Greg Neiheisel (JIRA)" <ji...@apache.org> on 2016/09/21 04:31:20 UTC

[jira] [Commented] (AIRFLOW-258) Always load plugin executors

    [ https://issues.apache.org/jira/browse/AIRFLOW-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508702#comment-15508702 ] 

Greg Neiheisel commented on AIRFLOW-258:
----------------------------------------

Hey guys - this seems like the closest thing to an issue I'm seeing.

I have a custom executor and a custom operator as a plugin.  If I specify my custom executor in the config, airflow takes a different path than if I don't specify using the custom executor.  If I'm configured with a built in executor like LocalExecutor, the plugin loads fine.  If I'm configured to use my custom executor, then it loads the plugins which also loads the modules my custom operator is defined in, which is normal.  I'm subclassing BaseSensorOperator and as its importing modules it throws an error about not being able to import BaseOperator from airflow.models from airflow/operators/__init__.py.

Long story, any ideas on how to tackle this?  Would be glad to work on a PR with a bit of guidance.  Thanks!

> Always load plugin executors
> ----------------------------
>
>                 Key: AIRFLOW-258
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-258
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: plugins
>            Reporter: Alexandr Nikitin
>
> At the moment we load plugin executors only when the specified `EXECUTOR` field in config isn't from existing executors: 'LocalExecutor', 'CeleryExecutor', 'SequentialExecutor', 'MesosExecutor'.
> If the default executor belongs to existing executors we won't load plugins executors at all. This breaks if the plugin executor used in SubDAG.
> We should load plugin executors always.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)