[jira] [Commented] (FLINK-5778) Split FileStateHandle into fileName and basePath

["Stephan Ewen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866466#comment-15866466 ] 

Stephan Ewen commented on FLINK-5778:
-------------------------------------

I am not sure about this design. State handle immutability is something I would really like to preserve.

How about making all FileStateHandles consist of a base path and a file path?
  - When serializing, the SavepointSerializer stores only the file path
  - When deserializing, the new state handles are constructed from the root path of the checkpoint, and the name in the savepoint



> Split FileStateHandle into fileName and basePath
> ------------------------------------------------
>
>                 Key: FLINK-5778
>                 URL: https://issues.apache.org/jira/browse/FLINK-5778
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Ufuk Celebi
>            Assignee: Ufuk Celebi
>
> Store the statePath as a basePath and a fileName and allow to overwrite the basePath. We cannot overwrite the base path as long as the state handle is still in flight and not persisted. Otherwise we risk a resource leak.
> We need this in order to be able to relocate savepoints.
> {code}
> interface RelativeBaseLocationStreamStateHandle {
>    void clearBaseLocation();
>    void setBaseLocation(String baseLocation);
> }
> {code}
> FileStateHandle should implement this and the SavepointSerializer should forward the calls when a savepoint is stored or loaded, clear before store and set after load.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)