You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/04/01 13:37:35 UTC
[GitHub] zeppelin pull request #2212: [gh-pages] set max size for pagination btn & hi...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2212
[gh-pages] set max size for pagination btn & hide arrows when current page is first/last
### What is this PR for?
As the number of Helium packages is increasing, more pagination buttons will be generated accordingly. If we don't set `maxSize`, pagination layout will be broken when screen size is small. So I set max size to 5 for it.
And also hide unnecessary arrows when current page is on first & last. (related feedback is https://github.com/apache/zeppelin/pull/2174#issuecomment-289776096 suggested by @1ambda)
### What type of PR is it?
Improvement | gh-pages
### What is the Jira issue?
N/A
### How should this be tested?
Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and click pagination button
### Screenshots (if appropriate)
- before
- after
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin improve/pagination
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2212.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2212
----
commit 599e06369cd648def8c7e60ec839a2e7d630432a
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-04-01T13:20:55Z
Set maxSize for pagination
commit 3c7cba30d7c0afc5f45a6ebcbce72b4658bdb442
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2017-04-01T13:21:53Z
Hide unnecessary first & last button
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2212
Tested and works as describe. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2212
@AhyoungRyu sure. Let me test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2212: [gh-pages] set max size for pagination btn & hi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2212
@1ambda Can you help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2212: [gh-pages] set max size for pagination btn & hide arro...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2212
@1ambda Thanks.
CI failure is irrelevant with gh-pages change. Merge into gh-pages if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---