[GitHub] rfscholte commented on a change in pull request #12: [MSHADE-307] defaults for transformers and filters

[GitBox <gi...@apache.org>]

rfscholte commented on a change in pull request #12: [MSHADE-307] defaults for transformers and filters
URL: https://github.com/apache/maven-shade-plugin/pull/12#discussion_r243030597
 
 

 ##########
 File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java
 ##########
 @@ -822,6 +831,16 @@ private File resolveArtifactSources( Artifact artifact )
                 simpleFilters.add( new SimpleFilter( jars, filter.getIncludes(), filter.getExcludes() ) );
             }
         }
+        else if ( this.filters == null )
+        {
+            getLog().debug( "Adding META-INF/*.SF, META-INF/*.DSA and META-INF/*.RSA exclusions" );
 
 Review comment:
   Please create a method getDefaultFilters()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services