You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/05/26 09:30:18 UTC
[GitHub] [commons-lang] stevebosman-oc opened a new pull request, #898: Increase test coverage of ComparableUtils from 71% to 100%
stevebosman-oc opened a new pull request, #898:
URL: https://github.com/apache/commons-lang/pull/898
Static methods in ComparableUtils had 0 coverage this fixes that
Contributed on behalf of the @opencastsoftware open source team
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #898: Increase test coverage of ComparableUtils from 71% to 100%
Posted by GitBox <gi...@apache.org>.
garydgregory commented on PR #898:
URL: https://github.com/apache/commons-lang/pull/898#issuecomment-1138531452
Hi @stevebosman-oc
Thank you for your PR. Please rebase on git master so we can see the newly committed coverage.yml in action :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] stevebosman-oc commented on pull request #898: Increase test coverage of ComparableUtils from 71% to 100%
Posted by GitBox <gi...@apache.org>.
stevebosman-oc commented on PR #898:
URL: https://github.com/apache/commons-lang/pull/898#issuecomment-1138587091
I don't know how CharSequenceUtils coverage would have been affected. but the changes to ComparableUtils are pretty much what I expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] codecov-commenter commented on pull request #898: Increase test coverage of ComparableUtils from 71% to 100%
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #898:
URL: https://github.com/apache/commons-lang/pull/898#issuecomment-1138571742
# [Codecov](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#898](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a71c794) into [master](https://codecov.io/gh/apache/commons-lang/commit/3a0ba3c6ea58019c2bc7688c1566532239a67fcc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a0ba3c) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #898 +/- ##
============================================
+ Coverage 91.25% 91.30% +0.04%
- Complexity 7379 7386 +7
============================================
Files 188 188
Lines 15966 15966
Branches 2998 2998
============================================
+ Hits 14570 14577 +7
+ Misses 788 782 -6
+ Partials 608 607 -1
```
| [Impacted Files](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/org/apache/commons/lang3/CharSequenceUtils.java](https://codecov.io/gh/apache/commons-lang/pull/898/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvQ2hhclNlcXVlbmNlVXRpbHMuamF2YQ==) | `88.80% <0.00%> (+0.79%)` | :arrow_up: |
| [.../apache/commons/lang3/compare/ComparableUtils.java](https://codecov.io/gh/apache/commons-lang/pull/898/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvbGFuZzMvY29tcGFyZS9Db21wYXJhYmxlVXRpbHMuamF2YQ==) | `100.00% <0.00%> (+28.57%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3a0ba3c...a71c794](https://codecov.io/gh/apache/commons-lang/pull/898?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory merged pull request #898: Increase test coverage of ComparableUtils from 71% to 100%
Posted by GitBox <gi...@apache.org>.
garydgregory merged PR #898:
URL: https://github.com/apache/commons-lang/pull/898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org