You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/19 16:25:42 UTC
[jira] [Commented] (NIFI-3682) Add "Schema Access Strategy" to
Record Readers and Writers
[ https://issues.apache.org/jira/browse/NIFI-3682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975010#comment-15975010 ]
ASF GitHub Bot commented on NIFI-3682:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1681
NIFI-3682: Add "Schema Access Strategy" and "Schema Write Strategy" Record Readers and Writers; bug fixes.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3682
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1681.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1681
----
commit 52a887856d03d43dc927bd933ac3d2cbf528b48a
Author: Oleg Zhurakousky <ol...@suitcase.io>
Date: 2017-03-30T13:12:07Z
NIFI-1280 added support for RecordSchema in SchemaRegistry
Signed-off-by: Mark Payne <ma...@hotmail.com>
commit d4941f1c648890ac87dfa807e68bdbc825fc4501
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-03-30T14:19:54Z
NIFI-1280: Updated SimpleKeyValueSchemaRegistry to make use of new CHOICE RecordFieldType
- Update Record Readers to use SchemaRegistry controller service. Moved SchemaRegistry api into its own maven module and added to standard-services-api so that we can properly add dependencies on it. Code cleanup and bug fixes
commit 0fa3f934f32614afb19befe86e17739a5faa315f
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-04-07T12:54:10Z
NIFI-1280: Fixed checkstyle violations and license exclusions for RAT plugin
commit 8c3d4c7fbaba02d29dc7b3738b585c971e18c692
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-04-10T12:50:27Z
NIFI-3682: Added 'Schema Access Strategy' and 'Schema Write Strategy' properties to reader/writer services. Bug fixes.
commit dcedd3470249c9a3ed0dc2b25564927e2e2074de
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-04-10T14:05:17Z
NIFI-1280: Addressed feedback from PR Review
----
> Add "Schema Access Strategy" to Record Readers and Writers
> ----------------------------------------------------------
>
> Key: NIFI-3682
> URL: https://issues.apache.org/jira/browse/NIFI-3682
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Mark Payne
> Assignee: Mark Payne
> Fix For: 1.2.0
>
>
> Currently the record readers are mostly configured with a Schema Registry service and the name of the schema. We should instead allow user to choose one of several strategies for determining the schema: Schema Registry + schema.name attribute, Schema Registry + identifier and version embedded at start of record/stream, avro.schema attribute, embedded schema for cases like Avro where the schema can be embedded in the content itself.
> On the writer side, we should also expose these options in order to convey the schema information to others.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)