You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/06/23 08:37:17 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5145: ui: changes in migrate vm storage and migrate volume form
shwstppr opened a new pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145
### Description
Better forms in UI for migrating stopped VM and volumes
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-971225106
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492468
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492954
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954546705
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975368813
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975367754
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957075907
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-982531446
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954451937
<b>Trillian Build Failed (tid-2488)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957076612
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#discussion_r750910795
##########
File path: ui/src/components/view/StoragePoolSelectView.vue
##########
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <a-input-search
+ class="top-spaced"
+ :placeholder="$t('label.search')"
+ v-model="searchQuery"
Review comment:
Done, on query change page is set to `1`
##########
File path: ui/src/components/view/StoragePoolSelectView.vue
##########
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <a-input-search
+ class="top-spaced"
+ :placeholder="$t('label.search')"
+ v-model="searchQuery"
+ style="margin-bottom: 10px;"
+ @search="fetchStoragePools"
+ autoFocus />
+ <a-table
+ size="small"
+ style="overflow-y: auto"
+ :loading="loading"
+ :columns="columns"
+ :dataSource="storagePools"
+ :pagination="false"
+ :rowKey="record => record.id">
+ <span slot="suitabilityCustomTitle">
+ {{ $t('label.suitability') }}
+ <a-tooltip :title="$t('message.volume.state.primary.storage.suitability')" placement="top">
+ <a-icon type="info-circle" class="table-tooltip-icon" />
+ </a-tooltip>
+ </span>
+ <div slot="name" slot-scope="record">
+ {{ record.name }}
+ <a-tooltip v-if="record.name === $t('label.auto.assign')" :title="$t('message.migrate.volume.pool.auto.assign')" placement="top">
+ <a-icon type="info-circle" class="table-tooltip-icon" />
+ </a-tooltip>
+ </div>
+ <div slot="suitability" slot-scope="record">
+ <a-icon
+ class="host-item__suitability-icon"
+ type="check-circle"
+ theme="twoTone"
+ twoToneColor="#52c41a"
+ v-if="record.suitableformigration" />
+ <a-icon
+ class="host-item__suitability-icon"
+ type="close-circle"
+ theme="twoTone"
+ twoToneColor="#f5222d"
+ v-else />
+ </div>
+ <div slot="disksizetotal" slot-scope="record">
+ <span v-if="record.disksizetotal">{{ $bytesToHumanReadableSize(record.disksizetotal) }}</span>
+ </div>
+ <div slot="disksizeused" slot-scope="record">
+ <span v-if="record.disksizeused">{{ $bytesToHumanReadableSize(record.disksizeused) }}</span>
+ </div>
+ <div slot="disksizefree" slot-scope="record">
+ <span v-if="record.disksizetotal && record.disksizeused">{{ $bytesToHumanReadableSize(record.disksizetotal * 1 - record.disksizeused * 1) }}</span>
+ </div>
+ <template slot="select" slot-scope="record">
+ <a-radio
+ @click="updateSelection(record)"
+ :checked="selectedStoragePool != null && record.id === selectedStoragePool.id"></a-radio>
+ </template>
+ </a-table>
+ <a-pagination
+ class="top-spaced"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="totalCount"
+ :showTotal="total => `${$t('label.total')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="['10', '20', '40', '80', '100']"
+ @change="handleChangePage"
+ @showSizeChange="handleChangePageSize"
+ showSizeChanger>
+ <template slot="buildOptionText" slot-scope="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+</template>
+
+<script>
+import { api } from '@/api'
+
+export default {
+ name: 'VolumeStoragePoolSelector',
+ props: {
+ resource: {
+ type: Object,
+ required: true
+ },
+ clusterId: {
+ type: String,
+ required: false,
+ default: null
+ },
+ suitabilityEnabled: {
+ type: Boolean,
+ required: false,
+ default: false
+ },
+ autoAssignAllowed: {
+ type: Boolean,
+ required: false,
+ default: false
+ },
+ isOpen: {
+ type: Boolean,
+ required: false
+ }
+ },
+ data () {
+ return {
+ loading: false,
+ storagePools: [],
+ searchQuery: '',
+ totalCount: 0,
+ page: 1,
+ pageSize: 10,
+ selectedStoragePool: null,
+ columns: [
+ {
+ title: this.$t('label.storageid'),
+ scopedSlots: { customRender: 'name' }
+ },
+ {
+ title: this.$t('label.clusterid'),
+ dataIndex: 'clustername'
+ },
+ {
+ title: this.$t('label.podid'),
+ dataIndex: 'podname'
+ },
+ {
+ title: this.$t('label.disksizetotal'),
+ scopedSlots: { customRender: 'disksizetotal' }
+ },
+ {
+ title: this.$t('label.disksizeused'),
+ scopedSlots: { customRender: 'disksizeused' }
+ },
+ {
+ title: this.$t('label.disksizefree'),
+ scopedSlots: { customRender: 'disksizefree' }
+ },
+ {
+ title: this.$t('label.select'),
+ scopedSlots: { customRender: 'select' }
+ }
+ ]
+ }
+ },
+ created () {
+ if (this.suitabilityEnabled) {
+ this.columns.splice(1, 0, { slots: { title: 'suitabilityCustomTitle' }, scopedSlots: { customRender: 'suitability' } }
+ )
+ }
+ this.preselectStoragePool()
+ this.fetchStoragePools()
+ },
+ methods: {
+ fetchStoragePools () {
+ if (this.suitabilityEnabled) {
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975367754
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954467787
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954448564
<b>Trillian Build Failed (tid-2487)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957099262
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957076612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492468
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-953746806
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954446519
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-953963150
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954450161
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954547172
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874494640
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5145 (SL-JID-324)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957075907
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#discussion_r750073620
##########
File path: ui/src/components/view/StoragePoolSelectView.vue
##########
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <a-input-search
+ class="top-spaced"
+ :placeholder="$t('label.search')"
+ v-model="searchQuery"
+ style="margin-bottom: 10px;"
+ @search="fetchStoragePools"
+ autoFocus />
+ <a-table
+ size="small"
+ style="overflow-y: auto"
+ :loading="loading"
+ :columns="columns"
+ :dataSource="storagePools"
+ :pagination="false"
+ :rowKey="record => record.id">
+ <span slot="suitabilityCustomTitle">
+ {{ $t('label.suitability') }}
+ <a-tooltip :title="$t('message.volume.state.primary.storage.suitability')" placement="top">
+ <a-icon type="info-circle" class="table-tooltip-icon" />
+ </a-tooltip>
+ </span>
+ <div slot="name" slot-scope="record">
+ {{ record.name }}
+ <a-tooltip v-if="record.name === $t('label.auto.assign')" :title="$t('message.migrate.volume.pool.auto.assign')" placement="top">
+ <a-icon type="info-circle" class="table-tooltip-icon" />
+ </a-tooltip>
+ </div>
+ <div slot="suitability" slot-scope="record">
+ <a-icon
+ class="host-item__suitability-icon"
+ type="check-circle"
+ theme="twoTone"
+ twoToneColor="#52c41a"
+ v-if="record.suitableformigration" />
+ <a-icon
+ class="host-item__suitability-icon"
+ type="close-circle"
+ theme="twoTone"
+ twoToneColor="#f5222d"
+ v-else />
+ </div>
+ <div slot="disksizetotal" slot-scope="record">
+ <span v-if="record.disksizetotal">{{ $bytesToHumanReadableSize(record.disksizetotal) }}</span>
+ </div>
+ <div slot="disksizeused" slot-scope="record">
+ <span v-if="record.disksizeused">{{ $bytesToHumanReadableSize(record.disksizeused) }}</span>
+ </div>
+ <div slot="disksizefree" slot-scope="record">
+ <span v-if="record.disksizetotal && record.disksizeused">{{ $bytesToHumanReadableSize(record.disksizetotal * 1 - record.disksizeused * 1) }}</span>
+ </div>
+ <template slot="select" slot-scope="record">
+ <a-radio
+ @click="updateSelection(record)"
+ :checked="selectedStoragePool != null && record.id === selectedStoragePool.id"></a-radio>
+ </template>
+ </a-table>
+ <a-pagination
+ class="top-spaced"
+ size="small"
+ :current="page"
+ :pageSize="pageSize"
+ :total="totalCount"
+ :showTotal="total => `${$t('label.total')} ${total} ${$t('label.items')}`"
+ :pageSizeOptions="['10', '20', '40', '80', '100']"
+ @change="handleChangePage"
+ @showSizeChange="handleChangePageSize"
+ showSizeChanger>
+ <template slot="buildOptionText" slot-scope="props">
+ <span>{{ props.value }} / {{ $t('label.page') }}</span>
+ </template>
+ </a-pagination>
+ </div>
+</template>
+
+<script>
+import { api } from '@/api'
+
+export default {
+ name: 'VolumeStoragePoolSelector',
+ props: {
+ resource: {
+ type: Object,
+ required: true
+ },
+ clusterId: {
+ type: String,
+ required: false,
+ default: null
+ },
+ suitabilityEnabled: {
+ type: Boolean,
+ required: false,
+ default: false
+ },
+ autoAssignAllowed: {
+ type: Boolean,
+ required: false,
+ default: false
+ },
+ isOpen: {
+ type: Boolean,
+ required: false
+ }
+ },
+ data () {
+ return {
+ loading: false,
+ storagePools: [],
+ searchQuery: '',
+ totalCount: 0,
+ page: 1,
+ pageSize: 10,
+ selectedStoragePool: null,
+ columns: [
+ {
+ title: this.$t('label.storageid'),
+ scopedSlots: { customRender: 'name' }
+ },
+ {
+ title: this.$t('label.clusterid'),
+ dataIndex: 'clustername'
+ },
+ {
+ title: this.$t('label.podid'),
+ dataIndex: 'podname'
+ },
+ {
+ title: this.$t('label.disksizetotal'),
+ scopedSlots: { customRender: 'disksizetotal' }
+ },
+ {
+ title: this.$t('label.disksizeused'),
+ scopedSlots: { customRender: 'disksizeused' }
+ },
+ {
+ title: this.$t('label.disksizefree'),
+ scopedSlots: { customRender: 'disksizefree' }
+ },
+ {
+ title: this.$t('label.select'),
+ scopedSlots: { customRender: 'select' }
+ }
+ ]
+ }
+ },
+ created () {
+ if (this.suitabilityEnabled) {
+ this.columns.splice(1, 0, { slots: { title: 'suitabilityCustomTitle' }, scopedSlots: { customRender: 'suitability' } }
+ )
+ }
+ this.preselectStoragePool()
+ this.fetchStoragePools()
+ },
+ methods: {
+ fetchStoragePools () {
+ if (this.suitabilityEnabled) {
Review comment:
Set loading to true / false before / after api call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975371462
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975415745
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874494439
@sureshanaparti this is still wip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954466955
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954492036
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-953963150
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954903384
<b>Trillian test result (tid-2490)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30107 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5145-t2490-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on a change in pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#discussion_r750073039
##########
File path: ui/src/components/view/StoragePoolSelectView.vue
##########
@@ -0,0 +1,261 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <div>
+ <a-input-search
+ class="top-spaced"
+ :placeholder="$t('label.search')"
+ v-model="searchQuery"
Review comment:
On change, the page should be reset to zero
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-971225318
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-971266771
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957075907
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954446887
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-954449909
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-982561138
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-982529860
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874492954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975368813
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-975371033
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] NuxRo commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
NuxRo commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-982521191
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957081870
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5145 (SL-JID-801)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-956116200
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-957076612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5145: ui: changes in migrate vm storage and migrate volume form
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5145:
URL: https://github.com/apache/cloudstack/pull/5145#issuecomment-874494439
@sureshanaparti this is still wip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org