You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by "Ed Espino (JIRA)" <ji...@apache.org> on 2017/02/22 21:26:44 UTC
[jira] [Comment Edited] (HAWQ-1351) Remove tweets.tar.gz from the
code base and generate it dynamically when it is needed.
[ https://issues.apache.org/jira/browse/HAWQ-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879268#comment-15879268 ]
Ed Espino edited comment on HAWQ-1351 at 2/22/17 9:26 PM:
----------------------------------------------------------
Please note, comments in JSON are not semantically valid on purpose. I'll see if there is a way to annotate the multiple json test files we have with the usual AL license header. I will most likely track this under another Jira.
{quote}
JSON does not have comments. A JSON encoder MUST NOT output comments. Douglas Crockford - creator of json http://tech.groups.yahoo.com/group/json/message/152
{quote}
was (Author: espino):
Please note, comments in JSON are not semantically valid on purpose. I'll see if there is a way to annotate the multiple json test files we have with the usual AL license header. I will most likely track this under another Jira.
```
JSON does not have comments. A JSON encoder MUST NOT output comments. Douglas Crockford - creator of json http://tech.groups.yahoo.com/group/json/message/152
```
> Remove tweets.tar.gz from the code base and generate it dynamically when it is needed.
> --------------------------------------------------------------------------------------
>
> Key: HAWQ-1351
> URL: https://issues.apache.org/jira/browse/HAWQ-1351
> Project: Apache HAWQ
> Issue Type: Improvement
> Components: Build
> Reporter: Roman Shaposhnik
> Assignee: Ed Espino
>
> Remove the binary test tarball (tweets.tar.gz) from the source code base. The file should be generated dynamically from the test file pxf/pxf-json/src/test/resources/tweets-pp.json. The creation of the tarball will be moved to the build & test process.
> The file tweets.tar.gz is currently flagged by Apache RAT as a binary file. Removing this file will help avoid confusion during Apache release review process.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)