You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/15 17:39:50 UTC

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on a change in pull request #18925: Numpy Dot Large Tensor Fix

sandeep-krishnamurthy commented on a change in pull request #18925:
URL: https://github.com/apache/incubator-mxnet/pull/18925#discussion_r471017487



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -76,3 +77,11 @@ def test_softmax():
         true_output = np.full((SMALL_Y, LARGE_X), (1 / input_data.shape[axis]))
         output = npx.softmax(input_data, axis=axis)
         assert_almost_equal(output.asnumpy(), true_output, rtol=1e-5, atol=1e-5)
+
+@pytest.mark.skip(reason="CI hasn't switch to ILP64 OpenBLAS yet")

Review comment:
       Should we move this to nightly test folder?
   I was also thinking if we should have a decorator that we can use to mark tests as nightly tests. So we can keep operator tests in same files for maintainability but also not run as UTs for PR checks.
   
   @access2rohit wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org