You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/28 19:39:51 UTC

[GitHub] [samza] rmatharu commented on a change in pull request #1296: SAMZA-2475: Add a allocated resource expiry timeout in samza yarn type of apps

rmatharu commented on a change in pull request #1296: SAMZA-2475: Add a allocated resource expiry timeout in samza yarn type of apps
URL: https://github.com/apache/samza/pull/1296#discussion_r385885577
 
 

 ##########
 File path: samza-core/src/main/java/org/apache/samza/clustermanager/ClusterResourceManager.java
 ##########
 @@ -132,6 +132,9 @@ public ClusterResourceManager(Callback callback) {
 
   public abstract void stop(SamzaApplicationState.SamzaAppStatus status);
 
+  public boolean isResourceExpired(SamzaResource resource) {
 
 Review comment:
   javadoc please
   also, this method likely belongs in SamzaResource?
   (if it really needs to be here, needs to be abstract)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services