[GitHub] [ozone] mukul1987 commented on a change in pull request #2452: HDDS-5480. [Ozone-Streaming] Client and server should support stream setup.

[GitBox <gi...@apache.org>]

mukul1987 commented on a change in pull request #2452:
URL: https://github.com/apache/ozone/pull/2452#discussion_r674753841



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java
##########
@@ -170,8 +172,12 @@ public static RaftGroup newRaftGroup(Pipeline pipeline) {
   public static RaftClient newRaftClient(RpcType rpcType, Pipeline pipeline,
       RetryPolicy retryPolicy, GrpcTlsConfig tlsConfig,
       ConfigurationSource ozoneConfiguration) throws IOException {
+    // TODO: For now, always set leader as primary. In the future we should

Review comment:
       Lets create new jira for this

##########
File path: hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/XceiverClientGrpc.java
##########
@@ -283,6 +284,13 @@ public ContainerCommandResponseProto sendCommand(
     return responseProtoHashMap;
   }
 
+  // TODO: We need separate XceiverClientRatis and XceiverClientGrpc instances

Review comment:
       Lets create a jira for this

##########
File path: hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto
##########
@@ -100,6 +100,8 @@ enum Type {
   GetSmallFile = 16;
   CloseContainer = 17;
   GetCommittedBlockLength = 18;
+
+  StreamInit = 19;

Review comment:
       lets start this at 30.

##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -53,6 +53,24 @@
     <tag>OZONE, CONTAINER, MANAGEMENT</tag>
     <description>The ipc port number of container.</description>
   </property>
+  <property>
+    <name>dfs.container.ratis.datastream.ipc</name>
+    <value>9890</value>

Review comment:
       These values are different from the values in the java conf file.

##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/HddsDispatcher.java
##########
@@ -199,7 +199,8 @@ private ContainerCommandResponseProto dispatchRequest(
     boolean isWriteStage =
         (cmdType == Type.WriteChunk && dispatcherContext != null
             && dispatcherContext.getStage()
-            == DispatcherContext.WriteChunkStage.WRITE_DATA);
+            == DispatcherContext.WriteChunkStage.WRITE_DATA)
+            || (cmdType == Type.StreamInit);

Review comment:
       are there any callers sending stream init at this time ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org