You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Slim Bouguerra <sb...@hortonworks.com> on 2016/12/22 16:31:21 UTC
Re: Review Request 54966: Fix typo in druid service postgresql
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/
-----------------------------------------------------------
(Updated Dec. 22, 2016, 4:31 p.m.)
Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-19278
https://issues.apache.org/jira/browse/AMBARI-19278
Repository: ambari
Description
-------
Fix typo in the name of postgresql https://issues.apache.org/jira/browse/AMBARI-19278
Diffs
-----
ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py c06bebb
Diff: https://reviews.apache.org/r/54966/diff/
Testing
-------
Tested manually.
python -m discover -v
test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... /Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915: SyntaxWarning: assertion is always true, perhaps remove parentheses?
assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage retrieved = {1}. "
ok
test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_property_existence_check (test_stack_advisor.TestHDP26StackAdvisor) ... ok
test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
----------------------------------------------------------------------
Ran 6 tests in 0.200s
OK
Thanks,
Slim Bouguerra
Re: Review Request 54966: Fix typo in druid service postgresql
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/#review159976
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Dec. 22, 2016, 5:31 p.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54966/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 5:31 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix typo in the name of postgresql https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
> ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py c06bebb
>
> Diff: https://reviews.apache.org/r/54966/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> python -m discover -v
> test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... /Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915: SyntaxWarning: assertion is always true, perhaps remove parentheses?
> assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage retrieved = {1}. "
> ok
> test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_property_existence_check (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
>
> ----------------------------------------------------------------------
> Ran 6 tests in 0.200s
>
> OK
>
>
> Thanks,
>
> Slim Bouguerra
>
>
Re: Review Request 54966: Fix typo in druid service postgresql
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54966/#review159975
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Dec. 22, 2016, 4:31 p.m., Slim Bouguerra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54966/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 4:31 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-19278
> https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix typo in the name of postgresql https://issues.apache.org/jira/browse/AMBARI-19278
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-common.xml 39ede45
> ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py ee56899
> ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py c06bebb
>
> Diff: https://reviews.apache.org/r/54966/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
> python -m discover -v
> test_recommendAtlasConfigurations (test_stack_advisor.TestHDP26StackAdvisor) ... /Users/sbouguerra/Hdev/ambari/ambari-server/src/test/python/stacks/2.6/common/../../../../../main/resources/stacks/HDP/2.5/services/stack_advisor.py:915: SyntaxWarning: assertion is always true, perhaps remove parentheses?
> assert(llap_daemon_selected_queue_cap > 0, "'{0}' queue capacity percentage retrieved = {1}. "
> ok
> test_recommendDruidConfigurations_WithDerby (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_WithPostgresql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_heterogeneous_hosts (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_property_existence_check (test_stack_advisor.TestHDP26StackAdvisor) ... ok
> test_recommendDruidConfigurations_withMysql (test_stack_advisor.TestHDP26StackAdvisor) ... ok
>
> ----------------------------------------------------------------------
> Ran 6 tests in 0.200s
>
> OK
>
>
> Thanks,
>
> Slim Bouguerra
>
>