You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-cvs@httpd.apache.org by jo...@apache.org on 2005/01/27 22:40:07 UTC
svn commit: r128428 - /httpd/apreq/branches/multi-env-unstable/STATUS
Author: joes
Date: Thu Jan 27 13:40:04 2005
New Revision: 128428
URL: http://svn.apache.org/viewcvs?view=rev&rev=128428
Log:
Update my long-range goals for apreq_env_handle_t:
replace bucket_alloc and pool functions with simple
data strutures in apreq_parser_t (adding args to
parser constructor)
Modified:
httpd/apreq/branches/multi-env-unstable/STATUS
Modified: httpd/apreq/branches/multi-env-unstable/STATUS
Url: http://svn.apache.org/viewcvs/httpd/apreq/branches/multi-env-unstable/STATUS?view=diff&rev=128428&p1=httpd/apreq/branches/multi-env-unstable/STATUS&r1=128427&p2=httpd/apreq/branches/multi-env-unstable/STATUS&r2=128428
==============================================================================
--- httpd/apreq/branches/multi-env-unstable/STATUS (original)
+++ httpd/apreq/branches/multi-env-unstable/STATUS Thu Jan 27 13:40:04 2005
@@ -23,8 +23,6 @@
typedef struct apreq_env_module_t {
const char *name;
apr_uint32_t magic_number;
- apr_pool_t *(*pool)(apreq_env_handle_t *);
- apr_bucket_alloc_t *(*bucket_alloc)(apreq_env_handle_t *);
apr_status_t (*jar)(apreq_env_handle_t *, const apr_table_t **);
apr_status_t (*args)(apreq_env_handle_t *, const apr_table_t **);
@@ -48,12 +46,18 @@
void (*log)(const char *,int,int,apr_status_t,apreq_env_handle_t *,
const char *,va_list);
+ apr_pool_t *(*pool)(apreq_env_handle_t *);
+ apr_bucket_alloc_t *(*bucket_alloc)(apreq_env_handle_t *);
+
const char *(*temp_dir)(apreq_env_handle_t *, const char *);
apr_off_t (*max_body)(apreq_env_handle_t *,apr_off_t);
apr_ssize_t (*max_brigade)(apreq_env_handle_t *, apr_ssize_t);
If possible the log calls inside libapreq2 should be replaced by
error codes that either libapreq2 apps or modules can log (or not).
+ The pool and bucket_alloc functions should become simple pointers
+ in apreq_parser_t; env() doesn't need to provide them.
+
The rest are controls (temp_dir, max_body, max_brigade) that
users will need to configure, and libapreq2 parsers will need
to look at. However these APIs are missing status codes, for