[GitHub] [tvm] comaniac commented on a change in pull request #10014: Fix function number datatype from char to uint16_t

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #10014:
URL: https://github.com/apache/tvm/pull/10014#discussion_r789890404



##########
File path: src/runtime/crt/common/func_registry.c
##########
@@ -101,7 +101,8 @@ tvm_crt_error_t TVMMutableFuncRegistry_Create(TVMMutableFuncRegistry* reg, uint8
 
   reg->registry.names = (const char*)buffer;
   buffer[0] = 0;  // number of functions present in buffer.
-  buffer[1] = 0;  // end of names list marker.
+  buffer[1] = 0;

Review comment:
       Better to explicitly mention the purpose. Something like
   
   ```suggestion
     buffer[1] = 0; // note that we combine the first two elements to form a 16-bit function index.
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org