You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ba...@apache.org on 2010/09/07 07:01:31 UTC
svn commit: r993213 -
/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java
Author: baerrach
Date: Tue Sep 7 05:01:31 2010
New Revision: 993213
URL: http://svn.apache.org/viewvc?rev=993213&view=rev
Log:
[MECLIPSE-669] Don't report missing source/javadoc jars when download is false
Submitted by: Martijn Dashorst
Patch applied.
Modified:
maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java
Modified: maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java?rev=993213&r1=993212&r2=993213&view=diff
==============================================================================
--- maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java (original)
+++ maven/plugins/trunk/maven-eclipse-plugin/src/main/java/org/apache/maven/plugin/ide/AbstractIdeSupportMojo.java Tue Sep 7 05:01:31 2010
@@ -1040,16 +1040,9 @@ public abstract class AbstractIdeSupport
{
StringBuffer msg = new StringBuffer();
- if ( !missingSourceDependencies.isEmpty() )
+ if ( getDownloadSources() && !missingSourceDependencies.isEmpty() )
{
- if ( getDownloadSources() )
- {
- msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotavailable" ) ); //$NON-NLS-1$
- }
- else
- {
- msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotdownloaded" ) ); //$NON-NLS-1$
- }
+ msg.append( Messages.getString( "AbstractIdeSupportMojo.sourcesnotavailable" ) ); //$NON-NLS-1$
for ( Iterator it = missingSourceDependencies.iterator(); it.hasNext(); )
{
@@ -1059,16 +1052,9 @@ public abstract class AbstractIdeSupport
msg.append( "\n" ); //$NON-NLS-1$
}
- if ( !missingJavadocDependencies.isEmpty() )
+ if ( getDownloadJavadocs() && !missingJavadocDependencies.isEmpty() )
{
- if ( getDownloadJavadocs() )
- {
- msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotavailable" ) ); //$NON-NLS-1$
- }
- else
- {
- msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotdownloaded" ) ); //$NON-NLS-1$
- }
+ msg.append( Messages.getString( "AbstractIdeSupportMojo.javadocnotavailable" ) ); //$NON-NLS-1$
for ( Iterator it = missingJavadocDependencies.iterator(); it.hasNext(); )
{