You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/31 10:01:07 UTC

[GitHub] [incubator-nuttx] pussuw commented on a change in pull request #5919: arch/Kconfig: Add IRQ stack dependency to address environments

pussuw commented on a change in pull request #5919:
URL: https://github.com/apache/incubator-nuttx/pull/5919#discussion_r839410792



##########
File path: arch/Kconfig
##########
@@ -445,6 +445,7 @@ menuconfig ARCH_ADDRENV
 	bool "Address environments"
 	default n
 	depends on ARCH_HAVE_ADDRENV
+	depends on ARCH_INTERRUPTSTACK != 0

Review comment:
       It could be done but more complex to implement.
   
   A separate stack for exception handling is needed when address environments are in use. Using a common one is simple and effective, and as far as I could tell all targets (sabre6-quad, sama5, unreleased icicle) that use address environments also define an interrupt stack, because it is needed. So this change works for all.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org