[GitHub] [iceberg] rymurr commented on a change in pull request #2287: Add iceberg specific description on Spark UI

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2287:
URL: https://github.com/apache/iceberg/pull/2287#discussion_r585427890



##########
File path: spark3/src/main/java/org/apache/iceberg/actions/Spark3CreateAction.java
##########
@@ -187,4 +189,16 @@ protected String getMetadataLocation(Table table) {
   protected abstract Map<String, String> targetTableProps();
 
   protected abstract TableCatalog checkSourceCatalog(CatalogPlugin catalog);
+

Review comment:
       Same comment as for `BaseSparkAction` above.
   
   For my own benefit why do the spark3 actions have a different base and is this part of  what is being addressed by Antons refactor? Not a comment on this PR specifically, just me trying to learn the history.

##########
File path: spark/src/main/java/org/apache/iceberg/actions/ExpireSnapshotsAction.java
##########
@@ -210,7 +210,8 @@ public ExpireSnapshotsAction deleteWith(Consumer<String> newDeleteFunc) {
   }
 
   @Override
-  public ExpireSnapshotsActionResult execute() {
+  public ExpireSnapshotsActionResult doExecute() {
+    spark.sparkContext().setJobGroup("EXPIRE", "EXPIRE-SNAPSHOTS", false);

Review comment:
       I wonder if `protected JobGroupInfo jobGroup()` in `BaseSparkAction` would make it clearer to implementers that this info should be generated/supplied. Then `execute` in `BaseSparkAction` can call teh `jobGroup` method and set the context itself. I think that is more clear for non-spark experts.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org