You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/21 06:34:53 UTC
[GitHub] [flink] danny0405 opened a new pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
danny0405 opened a new pull request #12275:
URL: https://github.com/apache/flink/pull/12275
…not include constraints
## What is the purpose of the change
Fix the primary key constraint info loss for TableSchema SEDE with `DescriptorProperties`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc6de4913b48c82a220eda620fb58667e7e93642 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12275:
URL: https://github.com/apache/flink/pull/12275#discussion_r430239805
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -610,7 +626,9 @@ public DataType getDataType(String key) {
public Optional<TableSchema> getOptionalTableSchema(String key) {
// filter for number of fields
final int fieldCount = properties.keySet().stream()
- .filter((k) -> k.startsWith(key) && k.endsWith('.' + TABLE_SCHEMA_NAME))
+ .filter((k) -> k.startsWith(key)
+ // "key." is the prefix.
+ && SCHEMA_COLUMN_NAME_SUFFIX.matcher(k.substring(key.length() + 1)).matches())
Review comment:
I think the regex matching is a more general way to match column names for the long run, just remove some specific keys seems hacky from my side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12275:
URL: https://github.com/apache/flink/pull/12275#discussion_r430947071
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -669,6 +677,14 @@ public DataType getDataType(String key) {
}
}
+ // Extract unique constraints.
+ String pkConstraintNameKey = key + '.' + PRIMARY_KEY_NAME;
+ final Optional<String> pkConstraintNameOpt = optionalGet(pkConstraintNameKey);
+ if (pkConstraintNameOpt.isPresent()) {
+ final String pkColumnsKey = key + '.' + PRIMARY_KEY_COLUMNS;
+ final String columns = optionalGet(pkColumnsKey).orElseThrow(exceptionSupplier(pkColumnsKey));
+ schemaBuilder.primaryKey(pkConstraintNameOpt.get(), columns.split(","));
+ }
Review comment:
Throw an exception if the the name is not present?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12275:
URL: https://github.com/apache/flink/pull/12275#discussion_r429746785
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -241,6 +244,19 @@ public void putTableSchema(String key, TableSchema schema) {
Arrays.asList(WATERMARK_ROWTIME, WATERMARK_STRATEGY_EXPR, WATERMARK_STRATEGY_DATA_TYPE),
watermarkValues);
}
+
+ if (schema.getPrimaryKey().isPresent()) {
+ final UniqueConstraint uniqueConstraint = schema.getPrimaryKey().get();
+ final List<List<String>> uniqueConstraintValues = new ArrayList<>();
+ uniqueConstraintValues.add(Arrays.asList(
+ uniqueConstraint.getName(),
+ uniqueConstraint.getType().name(),
+ String.join(",", uniqueConstraint.getColumns())));
+ putIndexedFixedProperties(
+ key + '.' + CONSTRAINT_UNIQUE,
+ Arrays.asList(NAME, TYPE, CONSTRAINT_UNIQUE_COLUMNS),
+ uniqueConstraintValues);
+ }
Review comment:
Because we only support primary key now. I think we can have a dedicate primary key properties, so that we don't need to handle the index. For example:
```java
public static final String PRIMARY_KEY_NAME = "primary-key.name";
public static final String PRIMARY_KEY_COLUMNS = "primary-key.columns";
schema.getPrimaryKey().ifPresent(pk -> {
putString(key + "." + PRIMARY_KEY_NAME, pk.getName());
putString(key + "." + PRIMARY_KEY_COLUMNS, String.join(",", pk.getColumns()));
});
```
This is also helpful for users who write yaml:
```
tables:
- name: TableNumber1
type: source-table
schema:
primary-key
name: constraint1
columns: f1, f2
```
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -610,7 +626,9 @@ public DataType getDataType(String key) {
public Optional<TableSchema> getOptionalTableSchema(String key) {
// filter for number of fields
final int fieldCount = properties.keySet().stream()
- .filter((k) -> k.startsWith(key) && k.endsWith('.' + TABLE_SCHEMA_NAME))
+ .filter((k) -> k.startsWith(key)
+ // "key." is the prefix.
+ && SCHEMA_COLUMN_NAME_SUFFIX.matcher(k.substring(key.length() + 1)).matches())
Review comment:
We can just to exclude the primary key, then don't need the regex matching.
```
.filter((k) -> k.startsWith(key) && !k.startsWith(key + "." + PRIMARY_KEY) && k.endsWith('.' + NAME))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc6de4913b48c82a220eda620fb58667e7e93642 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #12275:
URL: https://github.com/apache/flink/pull/12275#discussion_r430998136
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -669,6 +677,14 @@ public DataType getDataType(String key) {
}
}
+ // Extract unique constraints.
+ String pkConstraintNameKey = key + '.' + PRIMARY_KEY_NAME;
+ final Optional<String> pkConstraintNameOpt = optionalGet(pkConstraintNameKey);
+ if (pkConstraintNameOpt.isPresent()) {
+ final String pkColumnsKey = key + '.' + PRIMARY_KEY_COLUMNS;
+ final String columns = optionalGet(pkColumnsKey).orElseThrow(exceptionSupplier(pkColumnsKey));
+ schemaBuilder.primaryKey(pkConstraintNameOpt.get(), columns.split(","));
+ }
Review comment:
Then I think we don't need to use `optionalGet` here, we can use `getString` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-633826597
> Btw, could you add a test for HiveCatalog that verifies the primary-key information is kept after `createTable` and `getTable`?
Sure, let me add an UT for Hive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc6de4913b48c82a220eda620fb58667e7e93642 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-633769853
Btw, could you add a test for HiveCatalog that verifies the primary-key information is kept after `createTable` and `getTable`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631912691
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bc6de4913b48c82a220eda620fb58667e7e93642 (Thu May 21 06:36:47 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on a change in pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #12275:
URL: https://github.com/apache/flink/pull/12275#discussion_r430989999
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
##########
@@ -669,6 +677,14 @@ public DataType getDataType(String key) {
}
}
+ // Extract unique constraints.
+ String pkConstraintNameKey = key + '.' + PRIMARY_KEY_NAME;
+ final Optional<String> pkConstraintNameOpt = optionalGet(pkConstraintNameKey);
+ if (pkConstraintNameOpt.isPresent()) {
+ final String pkColumnsKey = key + '.' + PRIMARY_KEY_COLUMNS;
+ final String columns = optionalGet(pkColumnsKey).orElseThrow(exceptionSupplier(pkColumnsKey));
+ schemaBuilder.primaryKey(pkConstraintNameOpt.get(), columns.split(","));
+ }
Review comment:
I think it is not necessary, the `schema.primary-key.columns` should never appear as a single(e.g. comes from `#putTableSchema`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
}, {
"hash" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2195",
"triggerID" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"triggerType" : "PUSH"
}, {
"hash" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2240",
"triggerID" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"triggerType" : "PUSH"
}, {
"hash" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2241",
"triggerID" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e027ff0822c8621eb8f061888cc15fd7465133ba Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
}, {
"hash" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2195",
"triggerID" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"triggerType" : "PUSH"
}, {
"hash" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2240",
"triggerID" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"triggerType" : "PUSH"
}, {
"hash" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2241",
"triggerID" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b848a7895db6b1b5263a5242e39b822fa30cecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2240)
* e027ff0822c8621eb8f061888cc15fd7465133ba Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] danny0405 commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631912098
Hi, @twalthr , can you take a look if you have time ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1983",
"triggerID" : "bc6de4913b48c82a220eda620fb58667e7e93642",
"triggerType" : "PUSH"
}, {
"hash" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2195",
"triggerID" : "0e4fff0b8b00cade33c00e9bb68f667dd11a1456",
"triggerType" : "PUSH"
}, {
"hash" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2240",
"triggerID" : "2b848a7895db6b1b5263a5242e39b822fa30cecc",
"triggerType" : "PUSH"
}, {
"hash" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e027ff0822c8621eb8f061888cc15fd7465133ba",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2b848a7895db6b1b5263a5242e39b822fa30cecc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2240)
* e027ff0822c8621eb8f061888cc15fd7465133ba UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #12275:
URL: https://github.com/apache/flink/pull/12275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-635057775
Merging...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12275: [FLINK-16021][table-common] DescriptorProperties.putTableSchema does …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12275:
URL: https://github.com/apache/flink/pull/12275#issuecomment-631915106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org