[GitHub] davisp commented on issue #477: Add LRU for view groups

[gi...@git.apache.org]

davisp commented on issue #477: Add LRU for view groups
URL: https://github.com/apache/couchdb/pull/477#issuecomment-315816869
 
 
   Re-reading this I guess I must have written down my concerns somewhere else and never got them on to this PR. My biggest concern with this change is a lack of profiling of what sort of bottleneck the new LRU might be. Given that its modeled off couch_server, and on a number of deployments we have more views than databases it seems like this is a prime candidate for another run away queue process.
   
   If we do want to pursue this I'd really want to see some serious benchmarking that shows its not just creating a second couch_server issue for us.
   
   Also, the original impetuous for this was to work on closing out views since its possible that large production environments can have some high memory usage requirements for all views to be open at once. An alternative approach that doesn't use an LRU would be to close idle views like we've added for databases and os processes. The recent PR for couch_db_updaters is here:
   
   https://github.com/apache/couchdb/commit/ba0c10bcf49be66b042d8f0deaf14bcfda1a49bf
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services