[GitHub] [spark] peter-toth commented on pull request #42038: [SPARK-42500][SQL] ConstantPropagation support more case

["peter-toth (via GitHub)" <gi...@apache.org>]

peter-toth commented on PR #42038:
URL: https://github.com/apache/spark/pull/42038#issuecomment-1637725994

   I think this PR is very similar to my https://github.com/apache/spark/pull/40268 so I'm fine with this this change.
   But my PR uses a mutable map to avoid the might be costly `val equalityPredicates = equalityPredicatesLeft ++ equalityPredicatesRight` map addition so please consider that PR too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org