You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/08/10 21:33:12 UTC
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7649
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil header files.
This is a follow-up for 154b07de73ca2b949fceacef6798411dc4a3c6eb.
This changelist does not contain any functional changes.
Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
---
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/port.h
M src/kudu/gutil/strings/escaping.cc
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
12 files changed, 54 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7649/1
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
Patch Set 4: Code-Review+2
Carrying over Dan's +2 from PS2.
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7649
to look at the new patch set (#4).
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil header files.
This is a follow-up for 154b07de73ca2b949fceacef6798411dc4a3c6eb.
This changelist does not contain any functional changes.
Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
---
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/port.h
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
11 files changed, 26 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7649/4
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/hash/hash.h
File src/kudu/gutil/hash/hash.h:
Line 97: namespace __gnu_cxx {
> warning: invalid case style for namespace '__gnu_cxx' [readability-identifi
Ignoring this due to obvious reasons.
Line 212: namespace __gnu_cxx {
> warning: invalid case style for namespace '__gnu_cxx' [readability-identifi
ditto
Line 403: namespace __gnu_cxx {
> warning: invalid case style for namespace '__gnu_cxx' [readability-identifi
ditto
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/join.h
File src/kudu/gutil/strings/join.h:
Line 10: #include <stdio.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/serialize.cc
File src/kudu/gutil/strings/serialize.cc:
Line 5: #include <stddef.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/serialize.h
File src/kudu/gutil/strings/serialize.h:
Line 10: #include <string.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/split.cc
File src/kudu/gutil/strings/split.cc:
Line 25: using std::iterator_traits;
> warning: using decl 'iterator_traits' is unused [misc-unused-using-decls]
Done
http://gerrit.cloudera.org:8080/#/c/7649/3/src/kudu/gutil/strings/split.h
File src/kudu/gutil/strings/split.h:
Line 23: #include <stddef.h>
> warning: #includes are not sorted properly [llvm-include-order]
Done
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil header files.
This is a follow-up for 154b07de73ca2b949fceacef6798411dc4a3c6eb.
This changelist does not contain any functional changes.
Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Reviewed-on: http://gerrit.cloudera.org:8080/7649
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/port.h
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
11 files changed, 26 insertions(+), 88 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil header files.
This is a follow-up for 154b07de73ca2b949fceacef6798411dc4a3c6eb.
This changelist does not contain any functional changes.
Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
---
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/port.h
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
11 files changed, 17 insertions(+), 83 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7649/2
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7649
to look at the new patch set (#3).
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
[gutil] remove the rest of 'using ...' from headers
Removed the rest of 'using ...' directives from gutil header files.
This is a follow-up for 154b07de73ca2b949fceacef6798411dc4a3c6eb.
This changelist does not contain any functional changes.
Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
---
M src/kudu/gutil/hash/hash.h
M src/kudu/gutil/port.h
M src/kudu/gutil/strings/escaping.h
M src/kudu/gutil/strings/join.h
M src/kudu/gutil/strings/serialize.cc
M src/kudu/gutil/strings/serialize.h
M src/kudu/gutil/strings/split.cc
M src/kudu/gutil/strings/split.h
M src/kudu/master/catalog_manager.cc
M src/kudu/server/tracing-path-handlers.cc
M src/kudu/tserver/tablet_server-test.cc
11 files changed, 16 insertions(+), 82 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/7649/3
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [gutil] remove the rest of 'using ...' from headers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [gutil] remove the rest of 'using ...' from headers
......................................................................
Patch Set 4:
Carrying over Dan's +2 from PS2.
--
To view, visit http://gerrit.cloudera.org:8080/7649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99e3fc83366fe7c7a5ddcc6e3b7b2028e3bc7a22
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No