You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Trustin Lee (JIRA)" <ji...@apache.org> on 2005/06/29 10:05:56 UTC

[jira] Created: (DIRMINA-68) Automatic reconnect configuration for client channels.

Automatic reconnect configuration for client channels.
------------------------------------------------------

         Key: DIRMINA-68
         URL: http://issues.apache.org/jira/browse/DIRMINA-68
     Project: Directory MINA
        Type: Improvement
    Reporter: Trustin Lee
 Assigned to: Trustin Lee 
     Fix For: 0.9


We need to provide:

* automatic reconnect property for client sessions
* reconnect delay
* max retry count

Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361582 ] 

Trustin Lee commented on DIRMINA-68:
------------------------------------

Thank you for your high-quality contribution.  It looks good!  But I want to point out some issues with this filter:

* Some people wants to use dynamic reconnect delay.  For example, the delay could be increased if connection attempt fails multiple times in a row.
* This filter won't work if the *first* connection attempt fails as you noticed.  I think we need a cleaner way to provide reconnection.

For example we could provide IoConnector.setReconnectPolicy( ReconnectPolicy ) method.  ReconnectPolicy will look like this:

public abstract class ReconnectPolicy {
    public static ReconnectPolicy NEVER = ..;

    public static ReconnectPolicy getInstance(int maxAttempts, int reconnectDelay);

    public abstract long nextReconnectTime( int nAttempts, Throwable reconnectCause );
}

WDYT?

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12355921 ] 

Julien Vermillard commented on DIRMINA-68:
------------------------------------------

a cleaner way of implementation would be to do it as a Filter

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Julien Vermillard updated DIRMINA-68:
-------------------------------------

    Attachment: ReconnectionFilter.java

working 0.8 reconnection filter, automaticly reconnect is the session is closed

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Trustin Lee updated DIRMINA-68:
-------------------------------

    Fix Version: 0.9.1
                     (was: 0.9)

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Barry Kaplan updated DIRMINA-68:
--------------------------------

    Attachment: MinaFailoverSession.java

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9
>  Attachments: MinaFailoverSession.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Trustin Lee updated DIRMINA-68:
-------------------------------

    Fix Version:     (was: 0.9.1)

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361750 ] 

Julien Vermillard commented on DIRMINA-68:
------------------------------------------

[...] So I think Trustin's idea is great.

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Julien Vermillard updated DIRMINA-68:
-------------------------------------

    Attachment: ReconnectionFilter.java

a idea of implementation

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361748 ] 

Julien Vermillard commented on DIRMINA-68:
------------------------------------------

we need a smart way to specify the reconnection policy. For example my needs are :  try 3 times (every 2 seconds) then retry endless every minute or simply retry every second. I'm sure other MINA  users got very differents needs.

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12316444 ] 

Trustin Lee commented on DIRMINA-68:
------------------------------------

Thank you for your contribution, Barry.  I'll take a look at it when I fix this issue. :)

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9
>  Attachments: MinaFailoverSession.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Trustin Lee updated DIRMINA-68:
-------------------------------

    Assign To:     (was: Trustin Lee)

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/DIRMINA-68?page=all ]

Julien Vermillard updated DIRMINA-68:
-------------------------------------

    Attachment: ReconnectionFilter.java

0.9 ReconnectionFilter

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Julien Vermillard (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361585 ] 

Julien Vermillard commented on DIRMINA-68:
------------------------------------------

so it would be a feature of IoConnector and not a filter ?

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Barry Kaplan (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12316439 ] 

Barry Kaplan commented on DIRMINA-68:
-------------------------------------

I attached a class that we are using for reconnection (MinaFailoverSession). It attempts to reconnect at periodic intervals (no backoff) against a set of addresses. Just idea fodder when this issue is implemented.

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>     Assignee: Trustin Lee
>      Fix For: 0.9
>  Attachments: MinaFailoverSession.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRMINA-68) Automatic reconnect configuration for client channels.

Posted by "Trustin Lee (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/DIRMINA-68?page=comments#action_12361589 ] 

Trustin Lee commented on DIRMINA-68:
------------------------------------

This integration makes our life easier.  :)

> Automatic reconnect configuration for client channels.
> ------------------------------------------------------
>
>          Key: DIRMINA-68
>          URL: http://issues.apache.org/jira/browse/DIRMINA-68
>      Project: Directory MINA
>         Type: Improvement
>     Reporter: Trustin Lee
>      Fix For: 0.9.1
>  Attachments: MinaFailoverSession.java, ReconnectionFilter.java, ReconnectionFilter.java, ReconnectionFilter.java
>
> We need to provide:
> * automatic reconnect property for client sessions
> * reconnect delay
> * max retry count
> Current retry count and client session flag will be stored as session attributes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira