You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org> on 2011/09/21 11:02:09 UTC

[jira] [Created] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
----------------------------------------------------------------------------------------------------------

                 Key: HBASE-4450
                 URL: https://issues.apache.org/jira/browse/HBASE-4450
             Project: HBase
          Issue Type: Test
            Reporter: Kannan Muthukkaruppan
            Assignee: Kannan Muthukkaruppan


Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109632#comment-13109632 ] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/#review1999
-----------------------------------------------------------

Ship it!


Sweet!  Great test and regression catcher.  Not sure if you wanted to commit this or just put it up to show.  Might actually be good to commit so then when the changes go in the test has just the diffs of behavior changes so it's easier to understand what it changes/optimizes?


https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
<https://reviews.apache.org/r/1998/#comment4508>

    license



https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
<https://reviews.apache.org/r/1998/#comment4509>

    update dir name



https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
<https://reviews.apache.org/r/1998/#comment4510>

    method takes cf but then doesn't use it?


- Jonathan


On 2011-09-21 09:10:27, Kannan Muthukkaruppan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1998/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-21 09:10:27)
bq.  
bq.  
bq.  Review request for Michael Stack and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block of its own).
bq.  The getData() calls all take a last argument which is the number of expected blocks read. Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434 in the next day or so, and at that time these counts should go down.
bq.  
bq.  
bq.  This addresses bug HBASE-4450.
bq.      https://issues.apache.org/jira/browse/HBASE-4450
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1998/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kannan
bq.  
bq.



> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-4450:
-------------------------

    Attachment: HBASE-4450.txt

>From rb

> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>         Attachments: HBASE-4450.txt
>
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113714#comment-13113714 ] 

stack commented on HBASE-4450:
------------------------------

Committed to 0.92 branch too.

> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>         Attachments: HBASE-4450.txt
>
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112290#comment-13112290 ] 

Ted Yu commented on HBASE-4450:
-------------------------------

Integrated to TRUNK.

Thanks for the patch Kannan.

Thanks for the review Jonathan.

> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113876#comment-13113876 ] 

Hudson commented on HBASE-4450:
-------------------------------

Integrated in HBase-0.92 #18 (See [https://builds.apache.org/job/HBase-0.92/18/])
    HBASE-4450 test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

stack : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java


> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>         Attachments: HBASE-4450.txt
>
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu resolved HBASE-4450.
---------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]

> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112312#comment-13112312 ] 

Hudson commented on HBASE-4450:
-------------------------------

Integrated in HBase-TRUNK #2242 (See [https://builds.apache.org/job/HBase-TRUNK/2242/])
    HBASE-4450  test for number of blocks read: to serve as baseline for expected
               blocks read and for catching regressions (Kannan)

tedyu : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java


> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109699#comment-13109699 ] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/#review2002
-----------------------------------------------------------

Ship it!


Got it, +1

- Jonathan


On 2011-09-21 09:10:27, Kannan Muthukkaruppan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1998/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-21 09:10:27)
bq.  
bq.  
bq.  Review request for Michael Stack and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block of its own).
bq.  The getData() calls all take a last argument which is the number of expected blocks read. Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434 in the next day or so, and at that time these counts should go down.
bq.  
bq.  
bq.  This addresses bug HBASE-4450.
bq.      https://issues.apache.org/jira/browse/HBASE-4450
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1998/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kannan
bq.  
bq.



> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109695#comment-13109695 ] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------



bq.  On 2011-09-21 16:31:40, Jonathan Gray wrote:
bq.  > Sweet!  Great test and regression catcher.  Not sure if you wanted to commit this or just put it up to show.  Might actually be good to commit so then when the changes go in the test has just the diffs of behavior changes so it's easier to understand what it changes/optimizes?

jgray: Yes, I would like to commit it separately, and then update with each of the fixes (like for hbase-4433, and 4434).


bq.  On 2011-09-21 16:31:40, Jonathan Gray wrote:
bq.  > https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java, line 1
bq.  > <https://reviews.apache.org/r/1998/diff/1/?file=44582#file44582line1>
bq.  >
bq.  >     license

will do. 


bq.  On 2011-09-21 16:31:40, Jonathan Gray wrote:
bq.  > https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java, line 43
bq.  > <https://reviews.apache.org/r/1998/diff/1/?file=44582#file44582line43>
bq.  >
bq.  >     update dir name

will do.


bq.  On 2011-09-21 16:31:40, Jonathan Gray wrote:
bq.  > https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java, lines 157-158
bq.  > <https://reviews.apache.org/r/1998/diff/1/?file=44582#file44582line157>
bq.  >
bq.  >     method takes cf but then doesn't use it?

In future, once the per CF/per block type metric is ported to open source branch, I would like to change the implementation to lookup cf.<cfName>.Data.fsBlockReadCnt. So would like to leave the cf argument for now.


- Kannan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/#review1999
-----------------------------------------------------------


On 2011-09-21 09:10:27, Kannan Muthukkaruppan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1998/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-09-21 09:10:27)
bq.  
bq.  
bq.  Review request for Michael Stack and Jonathan Gray.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block of its own).
bq.  The getData() calls all take a last argument which is the number of expected blocks read. Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434 in the next day or so, and at that time these counts should go down.
bq.  
bq.  
bq.  This addresses bug HBASE-4450.
bq.      https://issues.apache.org/jira/browse/HBASE-4450
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/1998/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Kannan
bq.  
bq.



> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109359#comment-13109359 ] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/
-----------------------------------------------------------

Review request for Michael Stack and Jonathan Gray.


Summary
-------

Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block of its own).
The getData() calls all take a last argument which is the number of expected blocks read. Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434 in the next day or so, and at that time these counts should go down.


This addresses bug HBASE-4450.
    https://issues.apache.org/jira/browse/HBASE-4450


Diffs
-----

  https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1998/diff


Testing
-------


Thanks,

Kannan



> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "Kannan Muthukkaruppan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13112276#comment-13112276 ] 

Kannan Muthukkaruppan commented on HBASE-4450:
----------------------------------------------

Can someone commit this please? After that I can submit a patch for HBASE-4434, which depends on/updates this test.

> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4450) test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions

Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109703#comment-13109703 ] 

jiraposter@reviews.apache.org commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/
-----------------------------------------------------------

(Updated 2011-09-21 17:49:19.772081)


Review request for Michael Stack and Jonathan Gray.


Changes
-------

added licence; fixed dir name; removed a tab.


Summary
-------

Test deliberately creates a table with blocksize = 1Byte (so that each KV is a block of its own).
The getData() calls all take a last argument which is the number of expected blocks read. Those numbers are the current baseline. I'll hope to submit patches for hbase-4433 & hbase-4434 in the next day or so, and at that time these counts should go down.


This addresses bug HBASE-4450.
    https://issues.apache.org/jira/browse/HBASE-4450


Diffs (updated)
-----

  https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1998/diff


Testing
-------


Thanks,

Kannan



> test for number of blocks read: to serve as baseline for expected blocks read and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as baseline for expected blocks read and for catching regressions. As optimizations for HBase-4433 or Hbase-4434 are committed, the test would need to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira