[GitHub] [phoenix] kadirozde commented on a change in pull request #739: PHOENIX-5788 Handling deletes on non-existing rows

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #739: PHOENIX-5788 Handling deletes on non-existing rows
URL: https://github.com/apache/phoenix/pull/739#discussion_r396229643
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java
 ##########
 @@ -517,6 +517,11 @@ private void applyPendingDeleteMutations(MiniBatchOperationInProgress<Mutation>
             }
             Put nextDataRowState = dataRowState.getSecond();
             if (nextDataRowState == null) {
+                if (dataRowState.getFirst() == null) {
 
 Review comment:
   Initially, I thought deleting a non-existing row would lead to false invalid row detection and filed this JIRA. Later I found that actually deleting a non-existing row does not confuse the IndexTool verification. This PR is just not to confuse humans when they inspect the raw mutations for mutable data and index tables as they would see a delete mutation on the data table and but no corresponding mutation on the index table. The check for non-existing row is done on the server side and thus it is not for immutable tables as you observed. The potential confusion for immutable table will be still there. I thought we should at least remove this possible confusion for mutable tables.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services