[GitHub] [incubator-superset] geido commented on a change in pull request #12060: feat: View all fav charts and dashboards

[GitBox <gi...@apache.org>]

geido commented on a change in pull request #12060:
URL: https://github.com/apache/incubator-superset/pull/12060#discussion_r544093688



##########
File path: superset-frontend/src/components/ListView/types.ts
##########
@@ -55,11 +55,14 @@ type FilterOperator =
   | 'all_text'
   | 'chart_all_text'
   | 'dataset_is_null_or_empty'
-  | 'between';
+  | 'between'
+  | 'dashboard_is_fav'
+  | 'chart_is_fav';
 
 export interface Filter {
   Header: ReactNode;
   id: string;
+  col?: string;

Review comment:
       The reason for this is because the backend is expecting the column "id" when filtering by favorite. But that is not very human friendly, as in the URL you will read a filter `filters=(id!t)`. Basically, with this have I added the ability to use a humanly friendly parameter while specifying the actual parameter that is sent to the backend for filtering. I am open to better ideas though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org