You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jan Kaluža <jk...@redhat.com> on 2013/08/22 14:29:07 UTC
Re: [PATCH] Fix "LDAPReferrals off"
On 07/10/2013 02:39 PM, Eric Covener wrote:
>> attached patch changes LDAPReferrals to tri-state logic.
>>
>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>> - "unset" - Does not call apr_ldap_set_option at all.
>
> +1, will let it stew here first and commit soon. PR54358 followup will
> maybe provide something to further control how unset (== enabled on
> openldap) will chase referrals but w/o rebind callback.
>
Hi, any luck with my patch? Do you have some comments regarding it? I
would really like to see this fixed also upstream :).
Regards,
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Eric Covener <co...@gmail.com>.
>> One of us still owes doc.
> Patch attached.
Thanks -- I committed it with some changes to break up the paragraph into a <dl>
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Jan Kaluža <jk...@redhat.com>.
On 08/26/2013 12:43 AM, Eric Covener wrote:
> Sorry, just got to it in 1517388. At the last second I did a
> s/unset/default (both are kind of misleading in their own way) -- let
> me know if you hate the change and I can put it back.
Thanks for the commit. This looks OK.
> One of us still owes doc.
Patch attached.
> On Thu, Aug 22, 2013 at 8:29 AM, Jan Kaluža <jk...@redhat.com> wrote:
>> On 07/10/2013 02:39 PM, Eric Covener wrote:
>>>>
>>>> attached patch changes LDAPReferrals to tri-state logic.
>>>>
>>>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>>>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>>>> - "unset" - Does not call apr_ldap_set_option at all.
>>>
>>>
>>> +1, will let it stew here first and commit soon. PR54358 followup will
>>> maybe provide something to further control how unset (== enabled on
>>> openldap) will chase referrals but w/o rebind callback.
>>>
>>
>> Hi, any luck with my patch? Do you have some comments regarding it? I would
>> really like to see this fixed also upstream :).
>>
>> Regards,
>> Jan Kaluza
>>
>
>
>
Jan Kaluza
Re: [PATCH] Fix "LDAPReferrals off"
Posted by Eric Covener <co...@gmail.com>.
Sorry, just got to it in 1517388. At the last second I did a
s/unset/default (both are kind of misleading in their own way) -- let
me know if you hate the change and I can put it back.
One of us still owes doc.
On Thu, Aug 22, 2013 at 8:29 AM, Jan Kaluža <jk...@redhat.com> wrote:
> On 07/10/2013 02:39 PM, Eric Covener wrote:
>>>
>>> attached patch changes LDAPReferrals to tri-state logic.
>>>
>>> - "on" - default. Calls apr_ldap_set_option to set referrals on.
>>> - "off" - Calls apr_ldap_set_option to turn referrals off.
>>> - "unset" - Does not call apr_ldap_set_option at all.
>>
>>
>> +1, will let it stew here first and commit soon. PR54358 followup will
>> maybe provide something to further control how unset (== enabled on
>> openldap) will chase referrals but w/o rebind callback.
>>
>
> Hi, any luck with my patch? Do you have some comments regarding it? I would
> really like to see this fixed also upstream :).
>
> Regards,
> Jan Kaluza
>
--
Eric Covener
covener@gmail.com