[jira] [Commented] (IMPALA-7110) Minor FE fixes suggested by error-prone

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502795#comment-16502795 ] 

ASF subversion and git services commented on IMPALA-7110:
---------------------------------------------------------

Commit f0ab334445046599b55415edece1c22e1ec27b1e in impala's branch refs/heads/master from [~tlipcon]
[ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=f0ab334 ]

IMPALA-7110. Fix errors from error-prone

* Fixes several cases of Preconditions.checkNotNull(<bool>) which were
  ineffective. Instead, we should use Preconditions.checkState.

* Fixed a case of synchronizing on a non-final class member, which is a
  bad practice.

* Fixed a case of trying to stringify an array instead of using Joiner
  to join it to a human-readable representation.

* Fixed a couple cases where the format string in String.format didn't
  match the number of arguments passed.

* Fixed a test where PrimitiveType objects were being used to look up
  elements in a Map<ScalarType, String>. This would always return null,
  so the test was ineffective.

I elected not to enable error-prone in the default maven profile since
it increases compilation time noticeably. It can be enabled by running
'mvn -Perrorprone'.

Even with this patch there are a bunch of warnings -- this only
addresses the issues that errorprone considers "errors".

Change-Id: Ie9bfadecb5b92bba4fc7921a6f87f249ed90e771
Reviewed-on: http://gerrit.cloudera.org:8080/10583
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Minor FE fixes suggested by error-prone
> ---------------------------------------
>
>                 Key: IMPALA-7110
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7110
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>            Reporter: Todd Lipcon
>            Priority: Minor
>
> Running google's 'error-prone' checker against the frontend yielded a few minor issues. Nothing appears to be functional - mostly ineffective Preconditions checks or faulty log messages. Nonetheless, worth fixing as minor cleanup.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org