You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "Nicklee007 (via GitHub)" <gi...@apache.org> on 2023/03/27 12:11:40 UTC
[GitHub] [bookkeeper] Nicklee007 opened a new pull request, #3888: Leak release ledgerHandler when no missing fragments in checkAllLedgers
Nicklee007 opened a new pull request, #3888:
URL: https://github.com/apache/bookkeeper/pull/3888
### Motivation
In checkAllLedgers when the ledger no missing fragments, will miss close ledgerHandler, which cause autorecovery not invoke `unregisterLedgerMetadataListener` to release ledger metadata listeners. Heap memory be used too much and maybe will cause OOM;
<img width="1567" alt="image" src="https://user-images.githubusercontent.com/84127069/227937422-1113af68-9bf3-4466-97fa-d9b7cc5d72be.png">
### Changes
1. Invoke` lh.closeAsync()` when no missing fragments;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 merged pull request #3888: Leak release ledgerHandler when no missing fragments in checkAllLedgers
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #3888:
URL: https://github.com/apache/bookkeeper/pull/3888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3888: Leak release ledgerHandler when no missing fragments in checkAllLedgers
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3888:
URL: https://github.com/apache/bookkeeper/pull/3888#issuecomment-1486086793
@horizonzy Would you please help take a look? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on pull request #3888: Leak release ledgerHandler when no missing fragments in checkAllLedgers
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on PR #3888:
URL: https://github.com/apache/bookkeeper/pull/3888#issuecomment-1486144115
I will include this PR in 4.16.0 and trigger a new RC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] Shoothzj commented on pull request #3888: Leak release ledgerHandler when no missing fragments in checkAllLedgers
Posted by "Shoothzj (via GitHub)" <gi...@apache.org>.
Shoothzj commented on PR #3888:
URL: https://github.com/apache/bookkeeper/pull/3888#issuecomment-1486150813
Nice catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org