[GitHub] [arrow-rs] sticnarf commented on a diff in pull request #4122: feat: add get_{ref, mut} to arrow_ipc Reader and Writer

["sticnarf (via GitHub)" <gi...@apache.org>]

sticnarf commented on code in PR #4122:
URL: https://github.com/apache/arrow-rs/pull/4122#discussion_r1176367914


##########
arrow-ipc/src/reader.rs:
##########
@@ -1038,6 +1038,20 @@ impl<R: Read + Seek> FileReader<R> {
             ))),
         }
     }
+
+    /// Gets a reference to the underlying reader.
+    ///
+    /// It is inadvisable to directly read from the underlying reader.

Review Comment:
   Sometimes reading doesn't require a mutable reference (e.g. `&File` implements `Read`), so I think the comment is worth having.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org