[GitHub] [pinot] walterddr commented on a change in pull request #7692: refactor DataTable and DataSchema to pinot-spi

[GitBox <gi...@apache.org>]

walterddr commented on a change in pull request #7692:
URL: https://github.com/apache/pinot/pull/7692#discussion_r743172970



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java
##########
@@ -175,8 +175,11 @@ public DataTableImplV3(ByteBuffer byteBuffer)
   }
 
   @Override
-  public void addException(ProcessingException processingException) {
-    _errCodeToExceptionMap.put(processingException.getErrorCode(), processingException.getMessage());
+  public void addException(Exception exception) {
+    if (exception instanceof ProcessingException) {
+      ProcessingException processingException = (ProcessingException) exception;
+      _errCodeToExceptionMap.put(processingException.getErrorCode(), processingException.getMessage());

Review comment:
       This is a workaround for the fact that. ProcessingException is a generated class that we can't include in spi --> because it will pull in unnecessary dependencies to the SPI module
   
   So instead I opted to relax the interface signature but tighten it during impl.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org