You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/29 15:28:01 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

exceptionfactory opened a new pull request #5422:
URL: https://github.com/apache/nifi/pull/5422


   #### Description of PR
   
   NIFI-9252 Removes the unused `nifi.sensitive.props.provider` property from `NiFiProperties` and also removes the related `nifi.minifi.sensitive.props.provider` property from MiNiFi. This property is no longer used following the refactoring of component property encryption for NIFI-7668 in #4809.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5422:
URL: https://github.com/apache/nifi/pull/5422#issuecomment-932387874


   > For consistency we should probably remove all (albeit harmless) references to the provider, in places like SensitivePropsSchema, RunMiNiFiTest, etc.
   
   Thanks for the feedback @mattyb149, that makes sense. I pushed an update removing the property from `SensitivePropsSchema` and `RunMiNiFiTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] exceptionfactory commented on pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on pull request #5422:
URL: https://github.com/apache/nifi/pull/5422#issuecomment-932521186


   Rebased from main and squashed commits to resolve conflict with Stateless Dataflow Configuration class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] markobean commented on pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

Posted by GitBox <gi...@apache.org>.
markobean commented on pull request #5422:
URL: https://github.com/apache/nifi/pull/5422#issuecomment-932320353


   Searched code for any remaining references to nifi.sensitive.props.provider. Found none. Any similar term searches show that the property is using hardcoded value "BC" where applicable (e.g. SensitivePropsSchema in minifi.)
   Also, built and started NiFi with this patch. No issues.
   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on pull request #5422:
URL: https://github.com/apache/nifi/pull/5422#issuecomment-932321844


   For consistency we should probably remove all (albeit harmless) references to the provider, in places like SensitivePropsSchema, RunMiNiFiTest, etc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #5422: NIFI-9252 Removed unused nifi.sensitive.props.provider Property

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #5422:
URL: https://github.com/apache/nifi/pull/5422


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org