You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/18 00:58:22 UTC

Review Request 43685: Refactored test helper code.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/
-----------------------------------------------------------

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
-------

Refactored test helper code.


Diffs
-----

  src/tests/mesos.hpp 242a11658c0a9ba4caced9b2b2bdbcb921f7fdd0 
  src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff 

Diff: https://reviews.apache.org/r/43685/diff/


Testing
-------

make check


Thanks,

Neil Conway


Re: Review Request 43685: Refactored test helper code.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/#review121579
-----------------------------------------------------------


Ship it!




- Joris Van Remoortere


On March 2, 2016, 2:20 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43685/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 2:20 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored test helper code.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 5f29085d7a491d8f672728228b824634ed42aeca 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
> 
> Diff: https://reviews.apache.org/r/43685/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Re: Review Request 43685: Refactored test helper code.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43685/
-----------------------------------------------------------

(Updated March 2, 2016, 2:20 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
-------

Rebase.


Repository: mesos


Description
-------

Refactored test helper code.


Diffs (updated)
-----

  src/tests/mesos.hpp 5f29085d7a491d8f672728228b824634ed42aeca 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 

Diff: https://reviews.apache.org/r/43685/diff/


Testing
-------

make check


Thanks,

Neil Conway