[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #935: Internal relocated version of Guava

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #935: Internal relocated version of Guava
URL: https://github.com/apache/incubator-iceberg/pull/935#discussion_r410474854
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
 ##########
 @@ -19,13 +19,13 @@
 
 package org.apache.iceberg;
 
-import com.google.common.base.Preconditions;
-import com.google.common.collect.ImmutableList;
-import com.google.common.collect.ListMultimap;
-import com.google.common.collect.Lists;
-import com.google.common.collect.Maps;
-import com.google.common.collect.Multimaps;
-import com.google.common.collect.Sets;
+import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
 
 Review comment:
   It may be fewer changes if we chose a different location to shade the dependencies, like `com.google.common.shaded`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org