You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/07/27 02:35:31 UTC
[Impala-ASF-CR] IMPALA-9798: Skip TestAutoScaling on EC runs
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13935
Change subject: IMPALA-9798: Skip TestAutoScaling on EC runs
......................................................................
IMPALA-9798: Skip TestAutoScaling on EC runs
TestAutoScaling uses ConcurrentWorkload, which does not set the
required query options to scan erasure-coded files. This change
disables the affected test when running with erasure-coding enabled.
Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/13935/1
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8798: Skip TestAutoScaling on EC runs
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Sahil Takiar, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13935
to look at the new patch set (#2).
Change subject: IMPALA-8798: Skip TestAutoScaling on EC runs
......................................................................
IMPALA-8798: Skip TestAutoScaling on EC runs
TestAutoScaling uses ConcurrentWorkload, which does not set the
required query options to scan erasure-coded files. This change
disables the affected test when running with erasure-coding enabled.
Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/13935/2
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-8798: Skip TestAutoScaling on EC runs
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13935 )
Change subject: IMPALA-8798: Skip TestAutoScaling on EC runs
......................................................................
Patch Set 1: Verified+1 Code-Review+2
(1 comment)
Thanks for the quick review, Sahil!
Marking this as verified since our pre-commit tests don't run with EC.
http://gerrit.cloudera.org:8080/#/c/13935/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/13935/1/tests/custom_cluster/test_auto_scaling.py@51
PS1, Line 51: @SkipIfEC.fix_later
> should we file a follow up JIRA for fixing this?
I don't intent to fix this. The change only serves to make sure that the AutoScaler class does not regress and remains useful for debugging and development. Autoscaling in general is supposed to be added by an orchestrating framework. Support for executor groups is tested separately in TestExecutorGroups.
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jul 2019 02:42:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8798: Skip TestAutoScaling on EC runs
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13935 )
Change subject: IMPALA-8798: Skip TestAutoScaling on EC runs
......................................................................
Patch Set 2: Verified+1 Code-Review+2
PS2: Carrying Sahil's +2 and my own Verified.
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jul 2019 02:42:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9798: Skip TestAutoScaling on EC runs
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13935 )
Change subject: IMPALA-9798: Skip TestAutoScaling on EC runs
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13935/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13935/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-9798
Did you mean IMPALA-8798?
http://gerrit.cloudera.org:8080/#/c/13935/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:
http://gerrit.cloudera.org:8080/#/c/13935/1/tests/custom_cluster/test_auto_scaling.py@51
PS1, Line 51: @SkipIfEC.fix_later
should we file a follow up JIRA for fixing this?
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jul 2019 02:38:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8798: Skip TestAutoScaling on EC runs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13935 )
Change subject: IMPALA-8798: Skip TestAutoScaling on EC runs
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4046/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Sat, 27 Jul 2019 03:17:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8798: Skip TestAutoScaling on EC runs
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13935 )
Change subject: IMPALA-8798: Skip TestAutoScaling on EC runs
......................................................................
IMPALA-8798: Skip TestAutoScaling on EC runs
TestAutoScaling uses ConcurrentWorkload, which does not set the
required query options to scan erasure-coded files. This change
disables the affected test when running with erasure-coding enabled.
Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Reviewed-on: http://gerrit.cloudera.org:8080/13935
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M tests/custom_cluster/test_auto_scaling.py
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I96690914f12679619ba96d79edde8af9cccf65fa
Gerrit-Change-Number: 13935
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>