You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2016/12/07 23:51:33 UTC
Review Request 54508: Added a TTY test for
LAUNCH_NESTED_CONTAINER_SESSION.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/
-----------------------------------------------------------
Review request for mesos and Anand Mazumdar.
Repository: mesos
Description
-------
Test verifies that output and error are sent as stdout to client.
Diffs
-----
src/tests/api_tests.cpp 6cd1f83a47731ee8c4fb1f022bf585b271b3b966
Diff: https://reviews.apache.org/r/54508/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54508: Added a TTY test for
LAUNCH_NESTED_CONTAINER_SESSION.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/
-----------------------------------------------------------
(Updated Dec. 12, 2016, 12:33 a.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
fixed typos. NNFR.
Repository: mesos
Description
-------
Test verifies that output and error are sent as stdout to client.
Diffs (updated)
-----
src/tests/api_tests.cpp 098804881c34acf53a43e332caa677c288bf8b06
Diff: https://reviews.apache.org/r/54508/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54508: Added a TTY test for
LAUNCH_NESTED_CONTAINER_SESSION.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/#review158587
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/api_tests.cpp (line 3861)
<https://reviews.apache.org/r/54508/#comment229363>
Nit: Quotes before `TTYInfo`
src/tests/api_tests.cpp (line 3862)
<https://reviews.apache.org/r/54508/#comment229364>
s/stederr/stderr
- Anand Mazumdar
On Dec. 8, 2016, 9:51 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54508/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 9:51 p.m.)
>
>
> Review request for mesos and Anand Mazumdar.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Test verifies that output and error are sent as stdout to client.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
>
> Diff: https://reviews.apache.org/r/54508/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 54508: Added a TTY test for
LAUNCH_NESTED_CONTAINER_SESSION.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 9:51 p.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
updated based on comments on dependent review.
Repository: mesos
Description
-------
Test verifies that output and error are sent as stdout to client.
Diffs (updated)
-----
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54508/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 54508: Added a TTY test for
LAUNCH_NESTED_CONTAINER_SESSION.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54508/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 1:23 a.m.)
Review request for mesos and Anand Mazumdar.
Changes
-------
used `getProcessIO` helper
Repository: mesos
Description
-------
Test verifies that output and error are sent as stdout to client.
Diffs (updated)
-----
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
Diff: https://reviews.apache.org/r/54508/diff/
Testing
-------
make check
Thanks,
Vinod Kone