You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/16 09:53:11 UTC
[GitHub] [skywalking] EvanLjp opened a new pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
EvanLjp opened a new pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793
Please answer these questions before submitting pull request
- Why submit this pull request?
- New feature provided
- Improve performance
- Related issues
https://github.com/apache/skywalking/issues/4790
___
### New feature or improvement
- Describe the details and related test reports.
Distinct super size dataset config and common metrics config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `18.69%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 31.61% -18.70%
+ Complexity 2688 1700 -988
=============================================
Files 741 719 -22
Lines 18265 17755 -510
Branches 1765 1729 -36
=============================================
- Hits 9190 5614 -3576
- Misses 8344 11762 +3418
+ Partials 731 379 -352
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io commented on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `17.55%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 33.62% -17.56%
+ Complexity 2686 1488 -1198
=============================================
Files 1305 575 -730
Lines 28443 14301 -14142
Branches 3098 1314 -1784
=============================================
- Hits 14555 4808 -9747
+ Misses 13222 9165 -4057
+ Partials 666 328 -338
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1009 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `16.68%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 33.62% -16.69%
+ Complexity 2688 1943 -745
=============================================
Files 741 718 -23
Lines 18265 17716 -549
Branches 1765 1715 -50
=============================================
- Hits 9190 5957 -3233
- Misses 8344 11224 +2880
+ Partials 731 535 -196
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `2.38% <ø> (-50.00%)` | `0.00 <0.00> (-2.00)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-9.78%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [189 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.34% +0.02%
- Complexity 2688 2690 +2
============================================
Files 741 738 -3
Lines 18265 18259 -6
Branches 1765 1766 +1
============================================
+ Hits 9190 9192 +2
+ Misses 8344 8333 -11
- Partials 731 734 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | | | |
| ... and [3 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `8.32%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 41.98% -8.33%
+ Complexity 2688 2051 -637
============================================
Files 741 1302 +561
Lines 18265 28391 +10126
Branches 1765 3101 +1336
============================================
+ Hits 9190 11921 +2731
- Misses 8344 15798 +7454
+ Partials 731 672 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `2.38% <ø> (-50.00%)` | `0.00 <0.00> (-2.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `86.66% <100.00%> (-6.44%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [948 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426235754
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -52,14 +55,17 @@ public Model add(Class<?> aClass, int scopeId, Storage storage, boolean record)
// Check this scope id is valid.
DefaultScopeDefine.nameOf(scopeId);
+ // extract properties from class
Review comment:
already remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `51.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 0.00% -51.18%
============================================
Files 1305 157 -1148
Lines 28443 3887 -24556
Branches 3098 466 -2632
============================================
- Hits 14555 0 -14555
+ Misses 13222 3887 -9335
+ Partials 666 0 -666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1270 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426236276
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -99,14 +109,18 @@ private void retrieval(Class<?> clazz,
Column column = field.getAnnotation(Column.class);
modelColumns.add(
new ModelColumn(
- new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(), column
- .storageOnly(), column.dataType().isValue(), column.length()));
+ new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(),
+ column
+ .storageOnly(), column.dataType().isValue(), column.length()
+ ));
Review comment:
already change, Since code style is not installed this time, there will not be so many formatting problems next time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.33% -0.84%
- Complexity 2686 2691 +5
============================================
Files 1305 740 -565
Lines 28443 18265 -10178
Branches 3098 1766 -1332
============================================
- Hits 14555 9194 -5361
+ Misses 13222 8338 -4884
- Partials 666 733 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [878 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `23.46%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 27.70% -23.47%
+ Complexity 2686 1509 -1177
=============================================
Files 1305 709 -596
Lines 28443 17579 -10864
Branches 3098 1696 -1402
=============================================
- Hits 14555 4870 -9685
+ Misses 13222 12367 -855
+ Partials 666 342 -324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [992 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 49.44% -0.87%
+ Complexity 2688 2663 -25
============================================
Files 741 738 -3
Lines 18265 18259 -6
Branches 1765 1766 +1
============================================
- Hits 9190 9029 -161
- Misses 8344 8508 +164
+ Partials 731 722 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `35.71% <0.00%> (-64.29%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `25.49% <0.00%> (-54.91%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [8 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `23.39%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 26.91% -23.40%
+ Complexity 2688 1483 -1205
=============================================
Files 741 719 -22
Lines 18265 17742 -523
Branches 1765 1727 -38
=============================================
- Hits 9190 4776 -4414
- Misses 8344 12640 +4296
+ Partials 731 326 -405
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [274 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426158500
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
I am not following your meaning. Could you be more clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426229867
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
Is there a checkstyle file for skywalking, I want to set it in idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `15.29%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 35.01% -15.30%
+ Complexity 2688 1868 -820
=============================================
Files 741 737 -4
Lines 18265 18184 -81
Branches 1765 1764 -1
=============================================
- Hits 9190 6368 -2822
- Misses 8344 11366 +3022
+ Partials 731 450 -281
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-9.78%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426155629
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
Metrics may the data reach 30G per day, if it is below this, it can be adjusted to 1 for mostly users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `9.38%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 41.79% -9.39%
+ Complexity 2686 2300 -386
============================================
Files 1305 719 -586
Lines 28443 17745 -10698
Branches 3098 1728 -1370
============================================
- Hits 14555 7416 -7139
+ Misses 13222 9702 -3520
+ Partials 666 627 -39
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [916 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `20.21%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 30.95% -20.22%
+ Complexity 2686 1656 -1030
=============================================
Files 1305 719 -586
Lines 28443 17752 -10691
Branches 3098 1729 -1369
=============================================
- Hits 14555 5495 -9060
+ Misses 13222 11851 -1371
+ Partials 666 406 -260
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [980 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629626108
maybe the pipeline have some errors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.86%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.30% -0.87%
- Complexity 2686 2688 +2
============================================
Files 1305 740 -565
Lines 28443 18265 -10178
Branches 3098 1766 -1332
============================================
- Hits 14555 9188 -5367
+ Misses 13222 8344 -4878
- Partials 666 733 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [879 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 150 -591
Lines 18265 3748 -14517
Branches 1765 447 -1318
============================================
- Hits 9190 0 -9190
+ Misses 8344 3748 -4596
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [705 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `20.22%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 30.94% -20.23%
+ Complexity 2686 1657 -1029
=============================================
Files 1305 721 -584
Lines 28443 17763 -10680
Branches 3098 1729 -1369
=============================================
- Hits 14555 5497 -9058
+ Misses 13222 11861 -1361
+ Partials 666 405 -261
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [979 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `16.26%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 34.04% -16.27%
+ Complexity 2688 1838 -850
=============================================
Files 741 735 -6
Lines 18265 18159 -106
Branches 1765 1763 -2
=============================================
- Hits 9190 6183 -3007
- Misses 8344 11535 +3191
+ Partials 731 441 -290
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-9.78%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [194 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.32% +0.01%
- Complexity 2688 2690 +2
============================================
Files 741 740 -1
Lines 18265 18265
Branches 1765 1766 +1
============================================
+ Hits 9190 9192 +2
+ Misses 8344 8339 -5
- Partials 731 734 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `21.84%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 28.46% -21.85%
+ Complexity 2688 1547 -1141
=============================================
Files 741 719 -22
Lines 18265 17745 -520
Branches 1765 1728 -37
=============================================
- Hits 9190 5052 -4138
- Misses 8344 12353 +4009
+ Partials 731 340 -391
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `17.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 33.33% -17.85%
+ Complexity 2686 1803 -883
=============================================
Files 1305 737 -568
Lines 28443 18181 -10262
Branches 3098 1764 -1334
=============================================
- Hits 14555 6060 -8495
+ Misses 13222 11681 -1541
+ Partials 666 440 -226
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [961 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `23.28%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 27.88% -23.29%
+ Complexity 2686 1508 -1178
=============================================
Files 1305 719 -586
Lines 28443 17736 -10707
Branches 3098 1716 -1382
=============================================
- Hits 14555 4946 -9609
+ Misses 13222 12421 -801
+ Partials 666 369 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [992 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.32% +0.01%
- Complexity 2688 2690 +2
============================================
Files 741 740 -1
Lines 18265 18265
Branches 1765 1766 +1
============================================
+ Hits 9190 9192 +2
+ Misses 8344 8339 -5
- Partials 731 734 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...f176bdb](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.35% -0.82%
- Complexity 2686 2692 +6
============================================
Files 1305 740 -565
Lines 28443 18265 -10178
Branches 3098 1766 -1332
============================================
- Hits 14555 9197 -5358
+ Misses 13222 8337 -4885
- Partials 666 731 +65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [878 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426235790
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -52,14 +55,17 @@ public Model add(Class<?> aClass, int scopeId, Storage storage, boolean record)
// Check this scope id is valid.
DefaultScopeDefine.nameOf(scopeId);
+ // extract properties from class
List<ModelColumn> modelColumns = new ArrayList<>();
List<ExtraQueryIndex> extraQueryIndices = new ArrayList<>();
+ // extract
Review comment:
already remove it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.84%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 49.46% -0.85%
+ Complexity 2688 2666 -22
============================================
Files 741 740 -1
Lines 18265 18265
Branches 1765 1766 +1
============================================
- Hits 9190 9035 -155
- Misses 8344 8508 +164
+ Partials 731 722 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `35.71% <0.00%> (-64.29%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `25.49% <0.00%> (-54.91%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [4 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `6.38%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 44.79% -6.39%
+ Complexity 2686 2432 -254
============================================
Files 1305 719 -586
Lines 28443 17765 -10678
Branches 3098 1730 -1368
============================================
- Hits 14555 7957 -6598
+ Misses 13222 9142 -4080
Partials 666 666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [904 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `1.78%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 49.38% -1.79%
+ Complexity 2686 2659 -27
============================================
Files 1305 738 -567
Lines 28443 18259 -10184
Branches 3098 1766 -1332
============================================
- Hits 14555 9018 -5537
+ Misses 13222 8516 -4706
- Partials 666 725 +59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [882 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 49.49% -0.83%
+ Complexity 2688 2658 -30
============================================
Files 741 735 -6
Lines 18265 18209 -56
Branches 1765 1765
============================================
- Hits 9190 9012 -178
- Misses 8344 8470 +126
+ Partials 731 727 -4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `35.71% <0.00%> (-64.29%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `25.49% <0.00%> (-54.91%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `21.83%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 28.48% -21.84%
+ Complexity 2688 1547 -1141
=============================================
Files 741 719 -22
Lines 18265 17745 -520
Branches 1765 1728 -37
=============================================
- Hits 9190 5054 -4136
- Misses 8344 12351 +4007
+ Partials 731 340 -391
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426237249
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
##########
@@ -76,7 +79,6 @@
* @since 7.0.0 dayStep represents how many days a single one index represents. Default is 1, meaning no difference
* with previous versions. But if there isn't much traffic for single one day, user could set the step larger to
* reduce the number of indexes, and keep the TTL longer.
- *
Review comment:
When I add this line, it will still be cleared after formatting with skywalking code style
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `2.56%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 48.60% -2.57%
+ Complexity 2686 2636 -50
============================================
Files 1305 738 -567
Lines 28443 18259 -10184
Branches 3098 1766 -1332
============================================
- Hits 14555 8875 -5680
+ Misses 13222 8660 -4562
- Partials 666 724 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [882 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.90%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 49.41% -0.91%
+ Complexity 2688 2662 -26
============================================
Files 741 738 -3
Lines 18265 18259 -6
Branches 1765 1766 +1
============================================
- Hits 9190 9022 -168
- Misses 8344 8514 +170
+ Partials 731 723 -8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `35.71% <0.00%> (-64.29%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `25.49% <0.00%> (-54.91%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `2.46%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 48.71% -2.47%
+ Complexity 2686 2636 -50
============================================
Files 1305 737 -568
Lines 28443 18220 -10223
Branches 3098 1765 -1333
============================================
- Hits 14555 8875 -5680
+ Misses 13222 8621 -4601
- Partials 666 724 +58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [881 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `1.73%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 52.04% +1.73%
+ Complexity 2688 679 -2009
============================================
Files 741 160 -581
Lines 18265 3904 -14361
Branches 1765 466 -1299
============================================
- Hits 9190 2032 -7158
+ Misses 8344 1613 -6731
+ Partials 731 259 -472
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | | | |
| [...oap/server/core/cluster/ServiceQueryException.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9TZXJ2aWNlUXVlcnlFeGNlcHRpb24uamF2YQ==) | | | |
| [...e/analysis/manual/log/HTTPAccessLogDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9IVFRQQWNjZXNzTG9nRGlzcGF0Y2hlci5qYXZh) | | | |
| [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | | | |
| [...er/receiver/envoy/EnvoyMetricReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvRW52b3lNZXRyaWNSZWNlaXZlclByb3ZpZGVyLmphdmE=) | | | |
| [...king/oap/server/core/alarm/provider/Threshold.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9UaHJlc2hvbGQuamF2YQ==) | | | |
| ... and [569 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426234482
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1} # The index shards number is for store metrics data rather than basic segment record
+ superDatasetIndexShardsFactor: ${SW_STORAGE_ES_SUPER_DATASET_INDEX_SHARDS_FACTOR:5} # If open segment record store, the segment shards number = indexShardsNumber * superDatasetIndexShardsFactor. And also in effect at Zipkin or Jaeger span data store.
Review comment:
```suggestion
superDatasetIndexShardsFactor: ${SW_STORAGE_ES_SUPER_DATASET_INDEX_SHARDS_FACTOR:5} # Super data set has been defined in the codes, such as trace segments. This factor provides more shards for the super data set, shards number = indexShardsNumber * superDatasetIndexShardsFactor. Also, this factor effects Zipkin and Jaeger traces.
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -52,14 +55,17 @@ public Model add(Class<?> aClass, int scopeId, Storage storage, boolean record)
// Check this scope id is valid.
DefaultScopeDefine.nameOf(scopeId);
+ // extract properties from class
List<ModelColumn> modelColumns = new ArrayList<>();
List<ExtraQueryIndex> extraQueryIndices = new ArrayList<>();
+ // extract
Review comment:
What does this mean?
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -119,7 +120,8 @@ storage:
user: ${SW_ES_USER:""}
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1} # The index shards number is for store metrics data rather than basic segment record
+ superDatasetIndexShardsFactor: ${SW_STORAGE_ES_SUPER_DATASET_INDEX_SHARDS_FACTOR:5} # If open segment record store, the segment shards number = indexShardsNumber * superDatasetIndexShardsFactor. And also in effect at Zipkin or Jaeger span data store.
Review comment:
```suggestion
superDatasetIndexShardsFactor: ${SW_STORAGE_ES_SUPER_DATASET_INDEX_SHARDS_FACTOR:5} # Super data set has been defined in the codes, such as trace segments. This factor provides more shards for the super data set, shards number = indexShardsNumber * superDatasetIndexShardsFactor. Also, this factor effects Zipkin and Jaeger traces.
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -99,14 +109,18 @@ private void retrieval(Class<?> clazz,
Column column = field.getAnnotation(Column.class);
modelColumns.add(
new ModelColumn(
- new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(), column
- .storageOnly(), column.dataType().isValue(), column.length()));
+ new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(),
+ column
+ .storageOnly(), column.dataType().isValue(), column.length()
+ ));
Review comment:
```suggestion
new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(),
column.storageOnly(), column.dataType().isValue(), column.length()
));
```
These lines seems should be layout better.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -52,14 +55,17 @@ public Model add(Class<?> aClass, int scopeId, Storage storage, boolean record)
// Check this scope id is valid.
DefaultScopeDefine.nameOf(scopeId);
+ // extract properties from class
Review comment:
What does this mean? This doesn't match the codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `16.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 34.02% -16.29%
+ Complexity 2688 1838 -850
=============================================
Files 741 737 -4
Lines 18265 18170 -95
Branches 1765 1763 -2
=============================================
- Hits 9190 6183 -3007
- Misses 8344 11546 +3202
+ Partials 731 441 -290
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-9.78%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [192 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `24.27%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 26.89% -24.28%
+ Complexity 2686 1479 -1207
=============================================
Files 1305 719 -586
Lines 28443 17726 -10717
Branches 3098 1715 -1383
=============================================
- Hits 14555 4768 -9787
+ Misses 13222 12609 -613
+ Partials 666 349 -317
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [991 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 151 -590
Lines 18265 3757 -14508
Branches 1765 448 -1317
============================================
- Hits 9190 0 -9190
+ Misses 8344 3757 -4587
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [704 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629655356
> maybe the pipeline have some errors
No, it isn't. This is caused by your wrong annotation, you need to check the log details. I have added comments about don't do this.
```
2020-05-16T13:16:14.3943402Z [ERROR] /home/runner/work/skywalking/skywalking/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/SuperDataset.java:34: error: reference not found
2020-05-16T13:16:14.3944515Z [ERROR] * @see org.apache.skywalking.oap.server.storage.plugin.zipkin.ZipkinSpanRecord
2020-05-16T13:16:14.3946150Z [ERROR] ^
2020-05-16T13:16:14.3947095Z [ERROR] /home/runner/work/skywalking/skywalking/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/SuperDataset.java:35: error: reference not found
2020-05-16T13:16:14.3948238Z [ERROR] * @see org.apache.skywalking.oap.server.storage.plugin.jaeger.JaegerSpanRecord
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426227303
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
the following image is a index in our preonline environmen(the number of endpoint is about 203)t:
in 0516, there are have 124060 docs, and the size of it is about 13.6M
From the data above, it seems that 30G can already store a lot of metrics data
Unless it is a very large system, I don't think it will exceed 30G
In es 6 ,the default shards number is 5
in es 7,the default shards number is 1 ,The reason is that the shards setting is unreasonable
So I think It's enough to set one shards for skywalking metrics data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `23.48%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 27.69% -23.49%
+ Complexity 2686 1509 -1177
=============================================
Files 1305 710 -595
Lines 28443 17587 -10856
Branches 3098 1696 -1402
=============================================
- Hits 14555 4870 -9685
+ Misses 13222 12375 -847
+ Partials 666 342 -324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [992 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 157 -584
Lines 18265 3887 -14378
Branches 1765 466 -1299
============================================
- Hits 9190 0 -9190
+ Misses 8344 3887 -4457
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [699 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `12.06%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 39.11% -12.07%
+ Complexity 2686 2176 -510
=============================================
Files 1305 719 -586
Lines 28443 17739 -10704
Branches 3098 1716 -1382
=============================================
- Hits 14555 6938 -7617
+ Misses 13222 10226 -2996
+ Partials 666 575 -91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [927 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426229973
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
Yes, of course. It is inside the root folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `17.11%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 34.05% -17.12%
+ Complexity 2686 1509 -1177
=============================================
Files 1305 575 -730
Lines 28443 14301 -14142
Branches 3098 1314 -1784
=============================================
- Hits 14555 4870 -9685
+ Misses 13222 9089 -4133
+ Partials 666 342 -324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1007 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426227503
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
OK, make sense. Please follow other comments to continue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `51.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 0.00% -51.18%
============================================
Files 1305 160 -1145
Lines 28443 3904 -24539
Branches 3098 466 -2632
============================================
- Hits 14555 0 -14555
+ Misses 13222 3904 -9318
+ Partials 666 0 -666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1269 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `15.69%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 34.62% -15.70%
+ Complexity 2688 1831 -857
=============================================
Files 741 719 -22
Lines 18265 17775 -490
Branches 1765 1731 -34
=============================================
- Hits 9190 6154 -3036
- Misses 8344 11202 +2858
+ Partials 731 419 -312
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [190 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `51.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 0.00% -51.18%
============================================
Files 1305 159 -1146
Lines 28443 3899 -24544
Branches 3098 466 -2632
============================================
- Hits 14555 0 -14555
+ Misses 13222 3899 -9323
+ Partials 666 0 -666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1270 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.33% +0.01%
- Complexity 2688 2690 +2
============================================
Files 741 740 -1
Lines 18265 18265
Branches 1765 1766 +1
============================================
+ Hits 9190 9193 +3
+ Misses 8344 8339 -5
- Partials 731 733 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9NZXRhZGF0YVF1ZXJ5LmphdmE=) | `58.64% <0.00%> (-0.76%)` | `11.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/context/util/PeerFormat.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1BlZXJGb3JtYXQuamF2YQ==) | | | |
| ... and [2 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 51.12% +0.81%
- Complexity 2688 2690 +2
============================================
Files 741 1306 +565
Lines 18265 28485 +10220
Branches 1765 3101 +1336
============================================
+ Hits 9190 14563 +5373
- Misses 8344 13257 +4913
+ Partials 731 665 -66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `96.66% <100.00%> (+3.56%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `32.25% <0.00%> (-30.25%)` | `8.00% <0.00%> (ø%)` | |
| ... and [876 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `20.33%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 30.84% -20.34%
+ Complexity 2686 1647 -1039
=============================================
Files 1305 719 -586
Lines 28443 17746 -10697
Branches 3098 1717 -1381
=============================================
- Hits 14555 5473 -9082
+ Misses 13222 11867 -1355
+ Partials 666 406 -260
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [981 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.35% -0.82%
- Complexity 2686 2692 +6
============================================
Files 1305 740 -565
Lines 28443 18265 -10178
Branches 3098 1766 -1332
============================================
- Hits 14555 9198 -5357
+ Misses 13222 8337 -4885
- Partials 666 730 +64
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [878 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `14.62%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 35.68% -14.63%
+ Complexity 2688 1908 -780
=============================================
Files 741 737 -4
Lines 18265 18184 -81
Branches 1765 1764 -1
=============================================
- Hits 9190 6489 -2701
- Misses 8344 11246 +2902
+ Partials 731 449 -282
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [169 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `21.95%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 28.35% -21.96%
+ Complexity 2688 1539 -1149
=============================================
Files 741 719 -22
Lines 18265 17745 -520
Branches 1765 1728 -37
=============================================
- Hits 9190 5032 -4158
- Misses 8344 12374 +4030
+ Partials 731 339 -392
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [246 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `12.08%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 39.08% -12.09%
+ Complexity 2686 2174 -512
=============================================
Files 1305 719 -586
Lines 28443 17738 -10705
Branches 3098 1715 -1383
=============================================
- Hits 14555 6933 -7622
+ Misses 13222 10228 -2994
+ Partials 666 577 -89
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [927 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `19.33%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 30.98% -19.34%
+ Complexity 2688 1663 -1025
=============================================
Files 741 719 -22
Lines 18265 17755 -510
Branches 1765 1729 -36
=============================================
- Hits 9190 5501 -3689
- Misses 8344 11874 +3530
+ Partials 731 380 -351
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-9.78%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [223 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.85%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.32% -0.86%
- Complexity 2686 2688 +2
============================================
Files 1305 738 -567
Lines 28443 18259 -10184
Branches 3098 1766 -1332
============================================
- Hits 14555 9188 -5367
+ Misses 13222 8338 -4884
- Partials 666 733 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [881 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `51.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 0.00% -51.18%
============================================
Files 1305 149 -1156
Lines 28443 3730 -24713
Branches 3098 444 -2654
============================================
- Hits 14555 0 -14555
+ Misses 13222 3730 -9492
+ Partials 666 0 -666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1274 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `20.57%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 30.59% -20.58%
+ Complexity 2686 1636 -1050
=============================================
Files 1305 719 -586
Lines 28443 17746 -10697
Branches 3098 1717 -1381
=============================================
- Hits 14555 5430 -9125
+ Misses 13222 11917 -1305
+ Partials 666 399 -267
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [983 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 49.48% -0.84%
+ Complexity 2688 2666 -22
============================================
Files 741 738 -3
Lines 18265 18259 -6
Branches 1765 1766 +1
============================================
- Hits 9190 9035 -155
- Misses 8344 8502 +158
+ Partials 731 722 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...gin/influxdb/query/ProfileThreadSnapshotQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeS5qYXZh) | `3.57% <0.00%> (-83.93%)` | `2.00% <0.00%> (-9.00%)` | |
| [...age/plugin/influxdb/query/ProfileTaskLogQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza0xvZ1F1ZXJ5LmphdmE=) | `15.15% <0.00%> (-78.79%)` | `2.00% <0.00%> (-4.00%)` | |
| [...er/storage/plugin/influxdb/base/NoneStreamDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL05vbmVTdHJlYW1EQU8uamF2YQ==) | `35.71% <0.00%> (-64.29%)` | `2.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/influxdb/query/ProfileTaskQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Qcm9maWxlVGFza1F1ZXJ5LmphdmE=) | `25.49% <0.00%> (-54.91%)` | `3.00% <0.00%> (-8.00%)` | |
| ... and [6 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 160 -581
Lines 18265 3904 -14361
Branches 1765 466 -1299
============================================
- Hits 9190 0 -9190
+ Misses 8344 3904 -4440
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [698 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.38% +0.07%
+ Complexity 2688 2683 -5
============================================
Files 741 735 -6
Lines 18265 18209 -56
Branches 1765 1765
============================================
- Hits 9190 9175 -15
+ Misses 8344 8298 -46
- Partials 731 736 +5
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-2.19%)` | `22.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 158 -583
Lines 18265 3892 -14373
Branches 1765 466 -1299
============================================
- Hits 9190 0 -9190
+ Misses 8344 3892 -4452
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [698 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `21.94%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 28.37% -21.95%
+ Complexity 2688 1537 -1151
=============================================
Files 741 717 -24
Lines 18265 17726 -539
Branches 1765 1715 -50
=============================================
- Hits 9190 5029 -4161
- Misses 8344 12356 +4012
+ Partials 731 341 -390
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [249 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426150703
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
This should be kept in 2, endpoint metrics could be a big size too.
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -119,7 +120,8 @@ storage:
user: ${SW_ES_USER:""}
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
Same here.
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
##########
@@ -32,7 +33,9 @@
@Setter
String protocol = "http";
@Setter
- private int indexShardsNumber = 2;
+ private int indexShardsNumber = 1;
+ @Setter
+ private int superDatasetIndexShardsFactor = 5;
Review comment:
Default values should follow the config file suggestions too.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -98,15 +107,17 @@ private void retrieval(Class<?> clazz,
if (field.isAnnotationPresent(Column.class)) {
Column column = field.getAnnotation(Column.class);
modelColumns.add(
- new ModelColumn(
- new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(), column
- .storageOnly(), column.dataType().isValue(), column.length()));
+ new ModelColumn(
+ new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(),
+ column
+ .storageOnly(), column.dataType().isValue(), column.length()));
Review comment:
These lines should not be re-formated.
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -62,16 +65,16 @@ protected boolean isExists(Model model) throws StorageException {
protected void createTable(Model model) throws StorageException {
ElasticSearchClient esClient = (ElasticSearchClient) client;
- Map<String, Object> settings = createSetting(model.isRecord());
+ Map<String, Object> settings = createSetting(model);
Map<String, Object> mapping = createMapping(model);
log.info("index {}'s columnTypeEsMapping builder str: {}", esClient.formatIndexName(model.getName()), mapping
- .toString());
+ .toString());
Review comment:
These lines should not be re-formated.
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
+ superDatasetIndexShardsFactor: ${SW_STORAGE_ES_SUPER_DATASET_INDEX_SHARDS_FACTOR:5} # superDataset shards number=factor*indexShardsNumber
Review comment:
As above, to be 3 should be enough.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/SuperDataset.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage.annotation;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+
+/**
+ * This annotation applies to super size dataset entities
+ * for example:
+ * <p>1. adjust the number of shards in es storage</p>
Review comment:
```suggestion
* <p>Storage implementation could provide different and specific optimization as this entity has much larger data set.</p>
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/SuperDataset.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage.annotation;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+
+/**
+ * This annotation applies to super size dataset entities
+ * for example:
+ * <p>1. adjust the number of shards in es storage</p>
+ *
+ * @see SegmentRecord
+ * @see org.apache.skywalking.oap.server.storage.plugin.zipkin.ZipkinSpanRecord
+ * @see org.apache.skywalking.oap.server.storage.plugin.jaeger.JaegerSpanRecord
Review comment:
These should be removed. This is core level annotation, those entities are only optional.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/SuperDataset.java
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.storage.annotation;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+import org.apache.skywalking.oap.server.core.analysis.manual.segment.SegmentRecord;
+
+/**
+ * This annotation applies to super size dataset entities
Review comment:
```suggestion
* This annotation applies to the supersize dataset entity.
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -119,8 +130,8 @@ private void retrieval(Class<?> clazz,
}
indexDefinitions.forEach(indexDefinition -> extraQueryIndices.add(new ExtraQueryIndex(
- column.columnName(),
- indexDefinition.withColumns()
+ column.columnName(),
+ indexDefinition.withColumns()
Review comment:
These lines should not be re-formated.
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java
##########
@@ -98,15 +107,17 @@ private void retrieval(Class<?> clazz,
if (field.isAnnotationPresent(Column.class)) {
Column column = field.getAnnotation(Column.class);
modelColumns.add(
- new ModelColumn(
- new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(), column
- .storageOnly(), column.dataType().isValue(), column.length()));
+ new ModelColumn(
+ new ColumnName(modelName, column.columnName()), field.getType(), column.matchQuery(),
+ column
+ .storageOnly(), column.dataType().isValue(), column.length()));
if (log.isDebugEnabled()) {
log.debug("The field named {} with the {} type", column.columnName(), field.getType());
}
if (column.dataType().isValue()) {
ValueColumnMetadata.INSTANCE.putIfAbsent(
- modelName, column.columnName(), column.dataType(), column.function(), column.defaultValue());
+ modelName, column.columnName(), column.dataType(), column.function(),
+ column.defaultValue());
Review comment:
These lines should not be re-formated.
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/StorageModuleElasticsearchConfig.java
##########
@@ -76,7 +79,6 @@
* @since 7.0.0 dayStep represents how many days a single one index represents. Default is 1, meaning no difference
* with previous versions. But if there isn't much traffic for single one day, user could set the step larger to
* reduce the number of indexes, and keep the TTL longer.
- *
Review comment:
These lines should not be re-formated.
##########
File path: oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -62,16 +65,16 @@ protected boolean isExists(Model model) throws StorageException {
protected void createTable(Model model) throws StorageException {
ElasticSearchClient esClient = (ElasticSearchClient) client;
- Map<String, Object> settings = createSetting(model.isRecord());
+ Map<String, Object> settings = createSetting(model);
Map<String, Object> mapping = createMapping(model);
log.info("index {}'s columnTypeEsMapping builder str: {}", esClient.formatIndexName(model.getName()), mapping
- .toString());
+ .toString());
try {
if (!esClient.isExistsTemplate(model.getName())) {
boolean isAcknowledged = esClient.createTemplate(model.getName(), settings, mapping);
log.info(
- "create {} index template finished, isAcknowledged: {}", model.getName(), isAcknowledged);
+ "create {} index template finished, isAcknowledged: {}", model.getName(), isAcknowledged);
Review comment:
These lines should not be re-formated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `0.81%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 50.35% -0.82%
- Complexity 2686 2692 +6
============================================
Files 1305 740 -565
Lines 28443 18265 -10178
Branches 3098 1766 -1332
============================================
- Hits 14555 9197 -5358
+ Misses 13222 8337 -4885
- Partials 666 731 +65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [878 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `16.88%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 34.28% -16.89%
+ Complexity 2686 1838 -848
=============================================
Files 1305 737 -568
Lines 28443 18184 -10259
Branches 3098 1764 -1334
=============================================
- Hits 14555 6234 -8321
+ Misses 13222 11508 -1714
+ Partials 666 442 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `83.33% <100.00%> (-13.22%)` | `17.00 <1.00> (-2.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [954 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `22.73%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 28.43% -22.74%
+ Complexity 2686 1544 -1142
=============================================
Files 1305 719 -586
Lines 28443 17738 -10705
Branches 3098 1715 -1383
=============================================
- Hits 14555 5044 -9511
+ Misses 13222 12350 -872
+ Partials 666 344 -322
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [982 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `23.49%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 27.67% -23.50%
+ Complexity 2686 1509 -1177
=============================================
Files 1305 711 -594
Lines 28443 17596 -10847
Branches 3098 1697 -1401
=============================================
- Hits 14555 4870 -9685
+ Misses 13222 12384 -838
+ Partials 666 342 -324
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| ... and [992 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] EvanLjp commented on a change in pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on a change in pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#discussion_r426229344
##########
File path: oap-server/server-bootstrap/src/main/resources/application.yml
##########
@@ -98,7 +98,8 @@ storage:
password: ${SW_ES_PASSWORD:""}
secretsManagementFile: ${SW_ES_SECRETS_MANAGEMENT_FILE:""} # Secrets management file in the properties format includes the username, password, which are managed by 3rd party tool.
dayStep: ${SW_STORAGE_DAY_STEP:1} # Represent the number of days in the one minute/hour/day index.
- indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
+ indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:1}
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `22.16%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 50.31% 28.15% -22.17%
+ Complexity 2688 1530 -1158
=============================================
Files 741 719 -22
Lines 18265 17745 -520
Branches 1765 1728 -37
=============================================
- Hits 9190 4996 -4194
- Misses 8344 12416 +4072
+ Partials 731 333 -398
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-11.44%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [252 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `50.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 0.00% -50.32%
============================================
Files 741 159 -582
Lines 18265 3899 -14366
Branches 1765 466 -1299
============================================
- Hits 9190 0 -9190
+ Misses 8344 3899 -4445
+ Partials 731 0 -731
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [699 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...34df429](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `2.80%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 48.37% -2.81%
+ Complexity 2686 2625 -61
============================================
Files 1305 738 -567
Lines 28443 18259 -10184
Branches 3098 1766 -1332
============================================
- Hits 14555 8832 -5723
+ Misses 13222 8711 -4511
- Partials 666 716 +50
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (-3.22%)` | `20.00 <1.00> (+1.00)` | :arrow_down: |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvRXRjZEVuZHBvaW50LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [886 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `12.07%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
=============================================
- Coverage 51.17% 39.09% -12.08%
+ Complexity 2686 2176 -510
=============================================
Files 1305 719 -586
Lines 28443 17745 -10698
Branches 3098 1728 -1370
=============================================
- Hits 14555 6938 -7617
+ Misses 13222 10232 -2990
+ Partials 666 575 -91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `0.00% <0.00%> (-79.72%)` | `0.00 <0.00> (-11.00)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `81.66% <100.00%> (-14.89%)` | `16.00 <1.00> (-3.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [926 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...002f4c2](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/544d419fc08d188a342f4b0490b8746131006aef&el=desc) will **decrease** coverage by `51.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 51.17% 0.00% -51.18%
============================================
Files 1305 151 -1154
Lines 28443 3757 -24686
Branches 3098 448 -2650
============================================
- Hits 14555 0 -14555
+ Misses 13222 3757 -9465
+ Partials 666 0 -666
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1272 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [544d419...f84bf3e](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
- Coverage 50.31% 50.30% -0.01%
+ Complexity 2688 2686 -2
============================================
Files 741 738 -3
Lines 18265 18259 -6
Branches 1765 1766 +1
============================================
- Hits 9190 9186 -4
+ Misses 8344 8339 -5
- Partials 731 734 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-2.19%)` | `22.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| ... and [5 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4793: Add a SuperDataset tag for custom super size dataset shards config in es storage
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4793:
URL: https://github.com/apache/skywalking/pull/4793#issuecomment-629620132
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=h1) Report
> Merging [#4793](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cffcc58f8fb5dcc2fbe186dede70c44b9e58703a&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4793 +/- ##
============================================
+ Coverage 50.31% 50.33% +0.02%
+ Complexity 2688 2686 -2
============================================
Files 741 736 -5
Lines 18265 18248 -17
Branches 1765 1766 +1
============================================
- Hits 9190 9186 -4
+ Misses 8344 8328 -16
- Partials 731 734 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <ø> (ø)` | `2.00 <0.00> (ø)` | |
| [...server/storage/plugin/jaeger/JaegerSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qYWVnZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vamFlZ2VyL0phZWdlclNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...server/storage/plugin/zipkin/ZipkinSpanRecord.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL1ppcGtpblNwYW5SZWNvcmQuamF2YQ==) | `2.70% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/oap/server/core/storage/model/StorageModels.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9TdG9yYWdlTW9kZWxzLmphdmE=) | `93.33% <100.00%> (+0.22%)` | `20.00 <1.00> (+1.00)` | |
| [...lasticsearch/StorageModuleElasticsearchConfig.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hDb25maWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [.../plugin/elasticsearch/base/StorageEsInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNJbnN0YWxsZXIuamF2YQ==) | `80.00% <100.00%> (+0.28%)` | `12.00 <0.00> (+1.00)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `91.86% <0.00%> (-2.33%)` | `9.00% <0.00%> (-2.00%)` | |
| [...rary/client/elasticsearch/ElasticSearchClient.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaENsaWVudC5qYXZh) | `56.83% <0.00%> (-2.19%)` | `22.00% <0.00%> (-1.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `63.15% <0.00%> (-1.76%)` | `14.00% <0.00%> (-1.00%)` | |
| ... and [7 more](https://codecov.io/gh/apache/skywalking/pull/4793/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=footer). Last update [cffcc58...b9c0d17](https://codecov.io/gh/apache/skywalking/pull/4793?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org