You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/21 08:59:50 UTC
[GitHub] [sling-org-apache-sling-auth-core] ghenzler opened a new pull request #5: Cleanup unit test
ghenzler opened a new pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5
request.getAttribute("path") is not used anymore in main code and should
not be mocked
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
ghenzler commented on a change in pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031
##########
File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath() throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when starting the changes for the resource mapping SPI - this is not needed anymore (and I gave the method a better name for the status quo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
ghenzler commented on a change in pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031
##########
File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath() throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when the changes for the resource mapping SPI - this is not needed anymore (and I gave the method a better name for the status quo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] ghenzler commented on a change in pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
ghenzler commented on a change in pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#discussion_r491888031
##########
File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath() throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when the changes for the resource mapping SPI - this is not needed anymore (and I gave the method a better name for the status quo)
##########
File path: src/test/java/org/apache/sling/auth/core/impl/SlingAuthenticatorTest.java
##########
@@ -373,19 +373,16 @@ public void test_emptyNodeAuthenticationHandlerPath() throws Throwable {
/**
* Mocks the request to accept method calls on path;
*
- * @param request http request
- * @param requestPath path in the http request
- * @param authProtectedPath path protected by the auth handler
+ * @param request http request
+ * @param requestPath request path
*/
- private void buildExpectationsForRequestPathAndAuthPath(final HttpServletRequest request,
- final String requestPath,
- final String authProtectedPath) {
+ private void buildExpectationsForRequest(final HttpServletRequest request,
+ final String requestPath) {
{
Mockito.when(request.getServletPath()).thenReturn(requestPath);
Mockito.when(request.getServerName()).thenReturn("localhost");
Mockito.when(request.getServerPort()).thenReturn(80);
Mockito.when(request.getScheme()).thenReturn("http");
- Mockito.when(request.getAttribute("path")).thenReturn(requestPath);
Review comment:
@cziegeler just stumbled upon this when starting the changes for the resource mapping SPI - this is not needed anymore (and I gave the method a better name for the status quo)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#issuecomment-695991263
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPO
T) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] ghenzler merged pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
ghenzler merged pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] ghenzler merged pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
ghenzler merged pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-auth-core] sonarcloud[bot] commented on pull request #5: Cleanup unit test
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #5:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/5#issuecomment-695991263
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPO
T) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=coverage&view=list) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-auth-core&pullRequest=5&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org