[GitHub] [doris] HappenLee commented on a diff in pull request #13039: [Vectorized][Function] support date_trunc and countequal function

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #13039:
URL: https://github.com/apache/doris/pull/13039#discussion_r990063292


##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -501,13 +598,17 @@ class FunctionOtherTypesToDateType : public IFunction {
 };
 
 using FunctionStrToDate = FunctionOtherTypesToDateType<StrToDate>;
-
 using FunctionMakeDate = FunctionOtherTypesToDateType<MakeDateImpl>;
+using FunctionDateTrunc = FunctionOtherTypesToDateType<DateTrunc<VecDateTimeValue, Int64>>;
+// using FunctionDateTruncV2 =

Review Comment:
   do not comment the code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org