You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/18 12:31:42 UTC

[GitHub] [pulsar] momo-jun commented on a diff in pull request #15200: [Improve][doc][txn] add brokerDeduplicationEnabled=true to enable transaction deduplication

momo-jun commented on code in PR #15200:
URL: https://github.com/apache/pulsar/pull/15200#discussion_r852085838


##########
site2/docs/txn-use.md:
##########
@@ -34,6 +34,12 @@ This section provides an example of how to use the transaction API to send and r
       ```
       acknowledgmentAtBatchIndexLevelEnabled=true
       ```
+    If you want to enable deduplication for transaction, follow the steps below.

Review Comment:
   Since it's a mandatory setting to enable transactions, I think it can be added to row28 following `systemTopicEnabled=true`.
   
   The following descriptions can be added:
   * `systemTopicEnabled=true` is a mandatory configuration. Otherwise, transactions cannot work because transaction buffer snapshots can’t be created.
   *  `brokerDeduplicationEnabled=true` is a mandatory configuration to guanrantee exactly-once semantics.
   
   BTW, does it make sense to add `standalone.conf` to row23?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org