[GitHub] [airflow] XD-DENG commented on a change in pull request #13379: Use 2.0.0 in Airflow docs & Breeze

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #13379:
URL: https://github.com/apache/airflow/pull/13379#discussion_r550076347



##########
File path: BREEZE.rst
##########
@@ -801,7 +801,7 @@ Generating constraints
 ----------------------
 
 Whenever setup.py gets modified, the CI master job will re-generate constraint files. Those constraint
-files are stored in separated orphan branches: ``constraints-master`` and ``constraint-1-10``.
+files are stored in separated orphan branches: ``constraints-master``, ``constraint-2-0`` and ``constraint-1-10``.

Review comment:
       ```suggestion
   files are stored in separated orphan branches: ``constraints-master``, ``constraints-2-0`` and ``constraints-1-10``.
   ```
   
   I tried to check the branches. These should be `constrains` rather than `constraint`.

##########
File path: BREEZE.rst
##########
@@ -1538,7 +1538,7 @@ This is the current syntax for  `./breeze <./breeze>`_:
 
         Generates pinned constraint files from setup.py. Those files are generated in files folder
         - separate files for different python version. Those constraint files when pushed to orphan
-        constraint-master and constraint-1-10 branches are used to generate repeatable
+        constraint-master, constraint-2-0 and constraint-1-10 branches are used to generate repeatable

Review comment:
       ```suggestion
           constraints-master, constraints-2-0 and constraints-1-10 branches are used to generate repeatable
   ```

##########
File path: CONTRIBUTING.rst
##########
@@ -756,7 +756,7 @@ when installing ``apache-airflow``, you might need to provide additional constra
 example ``pip install apache-airflow==1.10.2 Werkzeug<1.0.0``)
 
 However we now have ``constraints-<PYTHON_MAJOR_MINOR_VERSION>.txt`` files generated
-automatically and committed to orphan ``constraints-master`` and ``constraint-1-10`` branches based on
+automatically and committed to orphan ``constraints-master``, ``constraint-2-0` and ``constraint-1-10`` branches based on

Review comment:
       ```suggestion
   automatically and committed to orphan ``constraints-master``, ``constraints-2-0` and ``constraints-1-10`` branches based on
   ```

##########
File path: breeze
##########
@@ -1707,7 +1707,7 @@ ${CMDNAME} generate-constraints [FLAGS]
 
       Generates pinned constraint files from setup.py. Those files are generated in files folder
       - separate files for different python version. Those constraint files when pushed to orphan
-      constraint-master and constraint-1-10 branches are used to generate repeatable
+      constraint-master, constraint-2-0 and constraint-1-10 branches are used to generate repeatable

Review comment:
       ```suggestion
         constraints-master, constraints-2-0 and constraints-1-10 branches are used to generate repeatable
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org